Home » Mailing list archives » linux-kernel » 2010 » April » 19

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Lameter
Subject: Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages
Date: Monday, April 19, 2010 - 10:38 am

On Mon, 19 Apr 2010, Minchan Kim wrote:


Its not awkward but an optimization. The page can be placed on any node
but the user would prefer a certain node. Most of the NUMA things are
there for optimization purposes and not for correctness. If you must have
an allocation on certain nodes for correctness (like SLAB) then
GFP_THISNODE is used.


Its not clear to me that this renaming etc helps. You
must use GFP_THISNODE if allocation must occur from a certain node.
alloc_pages_exact_node results in more confusion because it does suggest
that fallback to other nodes is not allowed.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/6] Remove node's validity check in alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)
[PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)
[PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 4/6] change alloc function in vmemmap_alloc_block, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 5/6] change alloc function in __vmalloc_area_node, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 8:25 am)
Re: [PATCH 1/6] Remove node's validity check in alloc_pages, Mel Gorman, (Tue Apr 13, 8:32 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Mel Gorman, (Tue Apr 13, 8:48 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Tue Apr 13, 8:52 am)
Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, Mel Gorman, (Tue Apr 13, 8:59 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 9:01 am)
Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, Mel Gorman, (Tue Apr 13, 9:02 am)
Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Mel Gorman, (Tue Apr 13, 9:13 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Tue Apr 13, 9:14 am)
Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 9:20 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 2:37 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 4:40 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 4:55 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 5:02 pm)
Re: [PATCH 1/6] Remove node's validity check in alloc_pages, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:04 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:18 pm)
Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:19 pm)
Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:22 pm)
Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, Minchan Kim, (Tue Apr 13, 5:33 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Wed Apr 14, 5:23 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Wed Apr 14, 4:39 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Wed Apr 14, 6:31 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 12:21 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 1:00 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 1:15 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 2:40 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 3:08 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 3:21 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 3:33 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 4:43 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 4:49 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Fri Apr 16, 9:07 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Christoph Lameter, (Fri Apr 16, 9:10 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Lee Schermerhorn, (Fri Apr 16, 12:13 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 8:54 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 8:55 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Sun Apr 18, 11:49 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Sun Apr 18, 2:22 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 5:03 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Mon Apr 19, 2:05 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:38 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:45 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Mon Apr 19, 3:27 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Mon Apr 19, 5:20 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Mel Gorman, (Tue Apr 20, 8:05 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Wed Apr 21, 3:48 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Wed Apr 21, 7:15 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Wed Apr 21, 10:06 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 22, 3:15 am)