RCU-isms in fs/nfs/delegation.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Monday, April 19, 2010 - 8:33 am

I'm trying to redo my NFS RCU warning fixup patch on top of Paul's patches,
and I've found a small potential bug: nfs_inode_reclaim_delegation() doesn't
use the appropriate accessors/locks to protect NFS_I(inode)->delegation, and
nor does it use such to protect *delegation that I can see.  It just
overwrites the record.

Furthermore, for consistency's sake, it should also protect accesses to
delegation->cred within that function.

Trond: can you confirm that both NFS_I(inode)->delegation and delegation->cred
should be considered RCU-protected pointers?

David
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RCU-isms in fs/nfs/delegation.c, David Howells, (Mon Apr 19, 8:33 am)
Re: RCU-isms in fs/nfs/delegation.c, Trond Myklebust, (Mon Apr 19, 10:32 am)
Re: RCU-isms in fs/nfs/delegation.c, David Howells, (Tue Apr 20, 1:48 am)
Re: RCU-isms in fs/nfs/delegation.c, Trond Myklebust, (Tue Apr 20, 5:29 am)
Re: RCU-isms in fs/nfs/delegation.c, David Howells, (Tue Apr 20, 5:49 am)