Re: [PATCH 7/7] ondemand: Solve the big performance issue with ondemand during disk IO

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Éric Piel
Date: Monday, April 19, 2010 - 7:30 am

On 19/04/10 15:43, Arjan van de Ven wrote:
Fair enough, and I have to fully agree, it's better to have a power
management which consumes a bit more than the unreachable optimal, than
having everyone switch it off completely.


Yes, but keep in mind the Linux ondemand governor should not be tweaked
only for the latest Intel CPUs. I've just done a very little and
_extremely rough_ measurement on my laptop with a Core Duo 2, and while
it seems that, indeed, at idle the frequency didn't matter for the
consumption (about 12.5W with any governor), when running updatedb (so
IO bound), the performance governor seems to consume more than ondemand
and powersave (14.8-15.8W instead of 14.0-14.6W). I'm very careful with
the results of this "experiment" because it's only using the ACPI report
for the power usage and done with many other programs in the background.
Nevertheless, it manages to convince me that this change is not going to
be as harmless for the power consumption as you suggest.

Don't take me wrong. Here, I'm not saying that this patch is bad per se.
In particular, I do understand the specific workloads it tries to
handle, and I don't have a better solution for it in mind. However, this
is quite a change in the ondemand governor logic, and the log message do
not mention anything about energy consumption. This triggers a big
warning "only half of the problem was looked at to get a solution"!

So if this patch ever goes in, it should at least have a better
changelog which describes what are the potential consequences on the
power consumption.

Cheers,
Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/7] Fix performance issue with ondemand governor, Arjan van de Ven, (Sun Apr 18, 11:59 am)
[PATCH 1/7] sched: add a comment to get_cpu_idle_time_us(), Arjan van de Ven, (Sun Apr 18, 12:00 pm)
[PATCH 2/7] sched: introduce a function to update the idle ..., Arjan van de Ven, (Sun Apr 18, 12:01 pm)
[PATCH 3/7] sched: update the idle statistics in get_cpu_i ..., Arjan van de Ven, (Sun Apr 18, 12:01 pm)
[PATCH 4/7] sched: fold updating of the last update time i ..., Arjan van de Ven, (Sun Apr 18, 12:02 pm)
[PATCH 5/7] sched: eliminate the ts->idle_lastupdate field, Arjan van de Ven, (Sun Apr 18, 12:02 pm)
[PATCH 6/7] sched: introduce get_cpu_iowait_time_us(), Arjan van de Ven, (Sun Apr 18, 12:03 pm)
[PATCH 7/7] ondemand: Solve the big performance issue with ..., Arjan van de Ven, (Sun Apr 18, 12:03 pm)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Mon Apr 19, 6:43 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Mon Apr 19, 6:46 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Éric Piel, (Mon Apr 19, 7:30 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Mon Apr 19, 7:47 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Mon Apr 19, 5:47 pm)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Thomas Renninger, (Tue Apr 20, 2:24 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Thomas Renninger, (Tue Apr 20, 2:29 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Tue Apr 20, 4:02 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Tue Apr 20, 4:07 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Thomas Renninger, (Fri Apr 23, 1:50 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Fri Apr 23, 6:52 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Fri Apr 23, 7:10 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Fri Apr 23, 9:06 am)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Arjan van de Ven, (Fri Apr 23, 9:08 am)
Re: [PATCH 0/7] Fix performance issue with ondemand governor, Dominik Brodowski, (Mon Apr 26, 2:45 pm)
Re: [PATCH 0/7] Fix performance issue with ondemand governor, Dominik Brodowski, (Mon Apr 26, 3:05 pm)
Re: [PATCH 7/7] ondemand: Solve the big performance issue ..., Thomas Renninger, (Tue Apr 27, 4:39 am)