login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
16
Re: [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Gui Jianfeng
Subject:
Re: [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
Date: Thursday, April 15, 2010 - 9:19 pm
Divyesh Shah wrote:
quoted text
> This fixes the lockdep warning reported by Gui Jianfeng. > > Signed-off-by: Divyesh Shah <dpshah@google.com>
This patch looks good to me. Reviewed-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
quoted text
> --- > > block/blk-cgroup.c | 7 +------ > block/blk-cgroup.h | 2 -- > block/cfq-iosched.c | 1 - > 3 files changed, 1 insertions(+), 9 deletions(-) > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index 80c1261..83930f6 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -86,12 +86,6 @@ struct blkio_cgroup *cgroup_to_blkio_cgroup(struct cgroup *cgroup) > } > EXPORT_SYMBOL_GPL(cgroup_to_blkio_cgroup); > > -void blkio_group_init(struct blkio_group *blkg) > -{ > - spin_lock_init(&blkg->stats_lock); > -} > -EXPORT_SYMBOL_GPL(blkio_group_init); > - > /* > * Add to the appropriate stat variable depending on the request type. > * This should be called with the blkg->stats_lock held. > @@ -349,6 +343,7 @@ void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg, > unsigned long flags; > > spin_lock_irqsave(&blkcg->lock, flags); > + spin_lock_init(&blkg->stats_lock); > rcu_assign_pointer(blkg->key, key); > blkg->blkcg_id = css_id(&blkcg->css); > hlist_add_head_rcu(&blkg->blkcg_node, &blkcg->blkg_list); > diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h > index 1d409ad..2c956a0 100644 > --- a/block/blk-cgroup.h > +++ b/block/blk-cgroup.h > @@ -217,7 +217,6 @@ extern void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg, > extern int blkiocg_del_blkio_group(struct blkio_group *blkg); > extern struct blkio_group *blkiocg_lookup_group(struct blkio_cgroup *blkcg, > void *key); > -void blkio_group_init(struct blkio_group *blkg); > void blkiocg_update_timeslice_used(struct blkio_group *blkg, > unsigned long time); > void blkiocg_update_dispatch_stats(struct blkio_group *blkg, uint64_t bytes, > @@ -235,7 +234,6 @@ struct cgroup; > static inline struct blkio_cgroup * > cgroup_to_blkio_cgroup(struct cgroup *cgroup) { return NULL; } > > -static inline void blkio_group_init(struct blkio_group *blkg) {} > static inline void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg, > struct blkio_group *blkg, void *key, dev_t dev) {} > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > index 0177109..62defd0 100644 > --- a/block/cfq-iosched.c > +++ b/block/cfq-iosched.c > @@ -961,7 +961,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create) > for_each_cfqg_st(cfqg, i, j, st) > *st = CFQ_RB_ROOT; > RB_CLEAR_NODE(&cfqg->rb_node); > - blkio_group_init(&cfqg->blkg); > > /* > * Take the initial reference that will be released on destroy > > > >
-- Regards Gui Jianfeng --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] blkio: Initialize blkg->stats_lock for the root cf ...
, Divyesh Shah
, (Thu Apr 15, 9:02 pm)
Re: [PATCH] blkio: Initialize blkg->stats_lock for the roo ...
, Gui Jianfeng
, (Thu Apr 15, 9:19 pm)
Re: [PATCH] blkio: Initialize blkg->stats_lock for the roo ...
, Jens Axboe
, (Thu Apr 15, 11:07 pm)
Re: [PATCH] blkio: Initialize blkg->stats_lock for the roo ...
, Vivek Goyal
, (Fri Apr 16, 6:18 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Re: [PATCH 1/1] staging: hv: Fix race condition on IC channel initialization (modi...
Sam Ravnborg
[PATCH 05/11] x86: add X86_64 dependency to x86_64 specific symbols in Kconfig.x86...
Christoph Lameter
Re: [PATCH 02/40] mm: slab allocation fairness
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Brian Swetland
Re: Attempted summary of suspend-blockers LKML thread
git
:
Felipe Contreras
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Paolo Ciarrocchi
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Sverre Rabbelier
Re: [GSoC] What is status of Git's Google Summer of Code 2008 projects?
Johannes Schindelin
Re: [PATCH] Fix install-doc-quick target
Peter Oberndorfer
Subject: [PATCH] fix stg edit command
linux-netdev
:
Andi Kleen
Re: RFC: Nagle latency tuning
Jarek Poplawski
Re: tc filter flow hash question
David Miller
Re: [RFC 0/5] generic rx recycling
Chuck Lever
Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
Jarek Poplawski
Re: socket api problem: can't bind an ipv6 socket to ::ffff:0.0.0.0
git-commits-head
:
Linux Kernel Mailing List
New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List
e1000e: Expose MDI-X status via ethtool change
Linux Kernel Mailing List
NFS: Store pages from an NFS inode into a local cache
Linux Kernel Mailing List
arm/imx/gpio: GPIO_INT_{HIGH,LOW}_LEV are not necessarily constant
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
openbsd-misc
:
Theo de Raadt
Re: RES: OpenBSD on IBM System X3550 7879
Bret S. Lambert
Re: any web management gui for pf ?
Leif Blixt
Re: Force passwordcheck in login.conf
Rob Shepherd
x86 hardware for router system
ropers
Re: Real men don't attack straw men
Colocation donated by:
Syndicate