Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass | KernelTrap

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Joe Perches

Subject: Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

Date: Thursday, April 15, 2010 - 8:57 am

On Thu, 2010-04-15 at 13:11 +0100, Alan Cox wrote:
quoted text> > Argument alignment
> Makes it take more space

Makes it look more like most kernel code.

quoted text> > Make chars static
> Not sure I see the point (compiler generates good code anyway)

Internal consistency.  2 use areas had it, 1 didn't.



--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/4] Various intel small device drivers, Alan Cox, (Wed Apr 14, 5:51 am)

[PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Alan Cox, (Wed Apr 14, 5:51 am)

[PATCH 2/4] isl29020: ambient light sensor, Alan Cox, (Wed Apr 14, 5:51 am)

[PATCH 3/4] liss331d1: accelerometer driver, Alan Cox, (Wed Apr 14, 5:52 am)

[PATCH 4/4] emc1403: thermal sensor support, Alan Cox, (Wed Apr 14, 5:52 am)

Re: [PATCH 0/4] Various intel small device drivers, Jean Delvare, (Wed Apr 14, 6:30 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Jonathan Cameron, (Wed Apr 14, 6:48 am)

Re: [PATCH 0/4] Various intel small device drivers, Alan Cox, (Wed Apr 14, 6:49 am)

Re: [PATCH 0/4] Various intel small device drivers, Jonathan Cameron, (Wed Apr 14, 6:55 am)

Re: [PATCH 0/4] Various intel small device drivers, Alan Cox, (Wed Apr 14, 7:19 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Alan Cox, (Wed Apr 14, 7:32 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Jonathan Cameron, (Wed Apr 14, 7:51 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Alan Cox, (Wed Apr 14, 8:19 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Jonathan Cameron, (Wed Apr 14, 9:39 am)

isl29020: ALS driver as misc device, Alan Cox, (Wed Apr 14, 9:56 am)

Re: isl29020: ALS driver as misc device, Greg KH, (Wed Apr 14, 10:01 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Joe Perches, (Wed Apr 14, 2:36 pm)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Éric Piel, (Wed Apr 14, 3:12 pm)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Daniel Mack, (Wed Apr 14, 3:34 pm)

Re: [PATCH 2/4] isl29020: ambient light sensor, Alan Cox, (Wed Apr 14, 3:35 pm)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Alan Cox, (Wed Apr 14, 3:37 pm)

Re: [PATCH 2/4] isl29020: ambient light sensor, Daniel Mack, (Wed Apr 14, 3:45 pm)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Neil Brown, (Wed Apr 14, 4:05 pm)

Re: [PATCH 2/4] isl29020: ambient light sensor, Daniel Mack, (Wed Apr 14, 11:20 pm)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Éric Piel, (Thu Apr 15, 2:47 am)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Alan Cox, (Thu Apr 15, 3:02 am)

Re: isl29020: ALS driver as misc device, Jonathan Cameron, (Thu Apr 15, 3:09 am)

Re: [PATCH 2/4] isl29020: ambient light sensor, Jonathan Cameron, (Thu Apr 15, 3:15 am)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Jonathan Cameron, (Thu Apr 15, 3:28 am)

Re: isl29020: ALS driver as misc device, Alan Cox, (Thu Apr 15, 4:17 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Alan Cox, (Thu Apr 15, 5:11 am)

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass, Joe Perches, (Thu Apr 15, 8:57 am)

Re: [PATCH 3/4] liss331d1: accelerometer driver, Pavel Machek, (Thu Apr 15, 12:12 pm)

Re: isl29020: ALS driver as misc device, Jonathan Cameron, (Mon Apr 26, 3:59 am)

Navigation

Popular discussions


linux-kernel:
David Brownell	Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':
Eberhard Moenkeberg	Re: OT: character encodings (was: Linux 2.6.20-rc4)
Andy Walls	Re: [PATCH 11/32] v4l/cx18: update workqueue usage
Thomas Gleixner	[patch -mm 19/28] x86_64: Use generic cmos update
Matthew Garrett	Re: 2.6.25-rc6 regression - hang on resume [Bug 10319]
git:
Mark Junker	git on MacOSX and files with decomposed utf-8 file names
Pat Thoyts	[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten	Re: 'git gc --aggressive' effectively unusable
Jonathan Nieder	Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patc...
Eric Raymond	git status --porcelain is a mess that needs fixing
linux-netdev:
David Miller	Re: [PATCH 32/53] netns xfrm: finding policy in netns
Jean-Louis Dupond	Re: tg3 driver not advertising 1000mbit
Jan Engelhardt	[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Matt Mackall	Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Eric Dumazet	Re: HTB accuracy on 10GbE
git-commits-head:
Linux Kernel Mailing List	V4L/DVB (8018): Add em2860 chip ID
Linux Kernel Mailing List	[ARM] unconditionally define __virt_to_phys and __phys_to_virt
Linux Kernel Mailing List	ARM: Add Versatile Express SMP support
Linux Kernel Mailing List	ixgbe: fix automatic LRO/RSC settings for low latency
Linux Kernel Mailing List	[CIFS] if get root inode fails during mount, cleanup tree connection
openbsd-misc:
Samuel Baldwin	Re: Forum engine
Robert	disklabel - cylinder rounding
nixlists	Re: Which laptops do the developers use?
Claudio Jeker	Re: OT: Python (was Re: vi in /bin)
L. V. Lammert	OT, .. but has anyone seen a crontab editor

Colocation donated by:

Syndicate