[PATCH] Reset ps/2 port should psmouse_probe fail before retrying

Previous thread: [PATCH 1/2] [RFC] block: replace BKL with global mutex by Arnd Bergmann on Wednesday, April 14, 2010 - 1:36 pm. (15 messages)

Next thread: [PATCH 1/3] perf: Make -f the default for perf record by Frederic Weisbecker on Wednesday, April 14, 2010 - 1:51 pm. (3 messages)
From: Peter M. Petrakis
Date: Wednesday, April 14, 2010 - 1:46 pm

Filed a bug on this too:

https://bugzilla.kernel.org/show_bug.cgi?id=15780

This particular laptop will lose it's synaptics touch
pad on return from suspend state. Reloading the psmouse
module makes no difference. I came up with the attached
work around which simply calls psmouse_reset on the
port should the initial probe fail. This solves the problem
for me and I've tested this on several laptops.

Initially discovered on Ubuntu 2.6.31 (karmic) and the problem
continues to exist in lucid 2.6.32. I've filed a bug against
ubuntu kernel here:

https://bugs.launchpad.net/oem-priority/+bug/551234

though the Ubuntu kernel team would really like to get upstream's
input on the matter before accepting the patch. Please
let me know what you think. Thanks.

Peter


From: Randy Dunlap
Date: Wednesday, April 14, 2010 - 2:04 pm

Hi,

Please send patches inline, not as attachments.
Use the full source file path in the patch.
Send the patch to linux-input@vger.kernel.org and cc: the Input
subsystem maintainer.

typo:  s/reseting/resetting/


Other than those 4 things, the patch looks OK to me.
Well, we would prefer not to have the
	((ret = __psmouse_probe(psmouse)) != 0)
inside the for expression if possible.  I.e., make the for(...) simpler.


Please read/review Documentation/SubmittingPatches.  Thanks.

---
~Randy
--

Previous thread: [PATCH 1/2] [RFC] block: replace BKL with global mutex by Arnd Bergmann on Wednesday, April 14, 2010 - 1:36 pm. (15 messages)

Next thread: [PATCH 1/3] perf: Make -f the default for perf record by Frederic Weisbecker on Wednesday, April 14, 2010 - 1:51 pm. (3 messages)