Re: [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP

Previous thread: linux-next: build warnings after merge of the final tree (scsi tree related) by Stephen Rothwell on Monday, April 12, 2010 - 11:21 pm. (2 messages)

Next thread: none
From: Stephen Rothwell
Date: Monday, April 12, 2010 - 11:34 pm

Hi all,

Changes since 20100412:

New trees: bkl-core
	bkl-procfs

Removed tree: reiserfs-bkl (end of life - at maintainer's request)

Dropped trees: tmio-mmc (long unresolved conflicts and unable to fetch)
	hwlat (at the maintainer's request)
	bkl-procfs (build problem)

My fixes tree contains:
	a patch for a pktcdvd build error from Arnd Bergmann

The v4l-dvb tree still has its build failure, so I used the version from
next-20100409.

The bkl-procfs tree gained a build failure, so I dropped it for today.

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 161 trees (counting Linus' and 22 trees of patches pending
for Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If ...
From: Randy Dunlap
Date: Tuesday, April 13, 2010 - 9:45 am

From: Randy Dunlap <randy.dunlap@oracle.com>

When EEEPC_WMI=y and INPUT_SPARSEKMAP=m, the build fails,
so make EEEPC_WMI depend on INPUT_SPARSEKMAP.

eeepc-wmi.c:(.text+0x28d1a9): undefined reference to `sparse_keymap_setup'
eeepc-wmi.c:(.text+0x28d1f9): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.text+0x28d2e0): undefined reference to `sparse_keymap_report_event'
eeepc-wmi.c:(.init.text+0x17069): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.exit.text+0x2bae): undefined reference to `sparse_keymap_free'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100413.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100413/drivers/platform/x86/Kconfig
@@ -388,7 +388,7 @@ config EEEPC_LAPTOP
 config EEEPC_WMI
 	tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
 	depends on ACPI_WMI
-	depends on INPUT
+	depends on INPUT && INPUT_SPARSEKMAP
 	depends on EXPERIMENTAL
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
--

From: Dmitry Torokhov
Date: Tuesday, April 13, 2010 - 3:39 pm

"select INPUT_SPARSEKMAP" please - users should not be concerned about
such implementation details.

-- 
Dmitry
--

From: Matthew Garrett
Date: Wednesday, April 14, 2010 - 5:34 am

I've queued up a patch for this.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--

Previous thread: linux-next: build warnings after merge of the final tree (scsi tree related) by Stephen Rothwell on Monday, April 12, 2010 - 11:21 pm. (2 messages)

Next thread: none