[PATCH 4/6] change alloc function in vmemmap_alloc_block

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Minchan Kim
Date: Tuesday, April 13, 2010 - 8:25 am

if node_state is N_HIGH_MEMORY, node doesn't have -1.
It means node's validity check is unnecessary.
So we can use alloc_pages_exact_node instead of alloc_pages_node.
It could avoid comparison and branch as 6484eb3e2a81807722 tried.

Cc: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 mm/sparse-vmemmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
index 392b9bb..7710ebc 100644
--- a/mm/sparse-vmemmap.c
+++ b/mm/sparse-vmemmap.c
@@ -53,7 +53,7 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node)
 		struct page *page;
 
 		if (node_state(node, N_HIGH_MEMORY))
-			page = alloc_pages_node(node,
+			page = alloc_pages_exact_node(node,
 				GFP_KERNEL | __GFP_ZERO, get_order(size));
 		else
 			page = alloc_pages(GFP_KERNEL | __GFP_ZERO,
-- 
1.7.0.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)
[PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 4/6] change alloc function in vmemmap_alloc_block, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 8:25 am)
Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 9:20 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 2:37 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 4:55 pm)
Re: [PATCH 1/6] Remove node's validity check in alloc_pages, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:04 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:18 pm)
Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:19 pm)
Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:22 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Fri Apr 16, 9:07 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Christoph Lameter, (Fri Apr 16, 9:10 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Lee Schermerhorn, (Fri Apr 16, 12:13 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Sun Apr 18, 11:49 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:38 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:45 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Wed Apr 21, 7:15 am)