[PATCH 1/6] Remove node's validity check in alloc_pages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Minchan Kim
Date: Tuesday, April 13, 2010 - 8:24 am

alloc_pages calls alloc_pages_node with numa_node_id().
alloc_pages_node can't see nid < 0.

So we can use alloc_pages_exact_node instead of alloc_pages_node.
It could avoid comparison and branch as 6484eb3e2a81807722 tried.

Cc: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 include/linux/gfp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 4c6d413..b65f003 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -308,7 +308,7 @@ extern struct page *alloc_page_vma(gfp_t gfp_mask,
 			struct vm_area_struct *vma, unsigned long addr);
 #else
 #define alloc_pages(gfp_mask, order) \
-		alloc_pages_node(numa_node_id(), gfp_mask, order)
+		alloc_pages_exact_node(numa_node_id(), gfp_mask, order)
 #define alloc_page_vma(gfp_mask, vma, addr) alloc_pages(gfp_mask, 0)
 #endif
 #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0)
-- 
1.7.0.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/6] Remove node's validity check in alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)
[PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)
[PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 8:25 am)
[PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 8:25 am)
Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 9:20 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 2:37 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 4:55 pm)
Re: [PATCH 1/6] Remove node's validity check in alloc_pages, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:04 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:18 pm)
Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:19 pm)
Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:22 pm)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Fri Apr 16, 9:07 am)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Christoph Lameter, (Fri Apr 16, 9:10 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Lee Schermerhorn, (Fri Apr 16, 12:13 pm)
Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Sun Apr 18, 11:49 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:38 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:45 am)
Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Wed Apr 21, 7:15 am)