Re: [PATCH] blkio: Changes to IO controller additional stats patches

Previous thread: [PATCH] blkio: Changes to IO controller additional stats patches by Divyesh Shah on Thursday, April 8, 2010 - 8:18 pm. (2 messages)

Next thread: [PATCH] Security: Fix coding style in security/ by wzt.wzt on Friday, April 9, 2010 - 4:30 am. (2 messages)
From: Divyesh Shah
Date: Thursday, April 8, 2010 - 8:27 pm

that include some minor fixes and addresses all comments.

Changelog: (most based on Vivek Goyal's comments)
o renamed blkiocg_reset_write to blkiocg_reset_stats
o more clarification in the documentation on io_service_time and io_wait_time
o Initialize blkg->stats_lock
o rename io_add_stat to blkio_add_stat and declare it static
o use bool for direction and sync
o derive direction and sync info from existing rq methods
o use 12 for major:minor string length
o define io_service_time better to cover the NCQ case
o add a separate reset_stats interface
o make the indexed stats a 2d array to simplify macro and function pointer code
o blkio.time now exports in jiffies as before
o Added stats description in patch description and
  Documentation/cgroup/blkio-controller.txt
o Prefix all stats functions with blkio and make them static as applicable
o replace IO_TYPE_MAX with IO_TYPE_TOTAL
o Moved #define constant to top of blk-cgroup.c
o Pass dev_t around instead of char *
o Add note to documentation file about resetting stats
o use BLK_CGROUP_MODULE in addition to BLK_CGROUP config option in #ifdef
  statements
o Avoid struct request specific knowledge in blk-cgroup. blk-cgroup.h now has
  rq_direction() and rq_sync() functions which are used by CFQ and when using
  io-controller at a higher level, bio_* functions can be added.

Signed-off-by: Divyesh Shah<dpshah@google.com>
---

 Documentation/cgroups/blkio-controller.txt |   48 +++++++
 block/blk-cgroup.c                         |  190 +++++++++++++---------------
 block/blk-cgroup.h                         |   64 ++++++---
 block/cfq-iosched.c                        |    8 +
 include/linux/blkdev.h                     |   18 +++
 5 files changed, 198 insertions(+), 130 deletions(-)

diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt
index 630879c..ed04fe9 100644
--- a/Documentation/cgroups/blkio-controller.txt
+++ b/Documentation/cgroups/blkio-controller.txt
@@ -77,7 +77,6 @@ ...
From: Jens Axboe
Date: Thursday, April 8, 2010 - 11:31 pm

Thanks, applied to 2.6.35.

-- 
Jens Axboe

--

From: Gui Jianfeng
Date: Monday, April 12, 2010 - 10:53 pm

Hi Jens,

Do not see this patch and other IO controller stats patches in 
for-2.6.35 branch. :)

Thanks,
Gui

--

From: Jens Axboe
Date: Monday, April 12, 2010 - 11:51 pm

They were stuck on my workstation, apparently forgot to push them out
before the weekend. Please check now and report if you think bits are
missing :-)

-- 
Jens Axboe

--

From: Vivek Goyal
Date: Friday, April 9, 2010 - 7:16 am

Thanks Divyesh.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

--

Previous thread: [PATCH] blkio: Changes to IO controller additional stats patches by Divyesh Shah on Thursday, April 8, 2010 - 8:18 pm. (2 messages)

Next thread: [PATCH] Security: Fix coding style in security/ by wzt.wzt on Friday, April 9, 2010 - 4:30 am. (2 messages)