Home » Mailing list archives » linux-kernel » 2010 » April » 13

linux-next: build failure after merge of the bkl-procfs tree

Previous thread: Compat-wireless for 2.6.34 - 802.11 and bluetooth backported by Luis R. Rodriguez on Monday, April 12, 2010 - 9:51 pm. (2 messages)

Next thread: [PATCH] Staging: comedi: fix macros do - while loop and spaces before tabs issues in comedidev.h by Gustavo Silva on Monday, April 12, 2010 - 11:13 pm. (2 messages)
[view original message]
From: Stephen Rothwell
Subject: linux-next: build failure after merge of the bkl-procfs tree
Date: Monday, April 12, 2010 - 10:27 pm

Hi "Frédéric,

After merging the bkl-procfs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/sunrpc/cache.c: In function 'cache_ioctl_procfs':
net/sunrpc/cache.c:1355: error: implicit declaration of function 'lock_kernel'
net/sunrpc/cache.c:1359: error: implicit declaration of function 'unlock_kernel'

Caused by commit 64ef834551d7696f54553d7608eba80a5a800e77 ("procfs: Push
down the bkl from ioctl").  Forgot to include linux/smp_lock.h?  See
Documentation/SubmitChecklist Rule #1.

I have dropped the bkl-procfs tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[ message continues ]
[view original message]
From: Frederic Weisbecker
Subject: [PATCH] sunrpc: Include missing smp_lock.h
Date: Tuesday, April 13, 2010 - 1:54 pm

Sorry about this.

I have pushed the following fix in the bkl/procfs branch.

Thanks.

---
Author: Frederic Weisbecker <fweisbec@gmail.com>
Date:   Tue Apr 13 22:46:36 2010 +0200

    sunrpc: Include missing smp_lock.h
    
    Now that cache_ioctl_procfs() calls the bkl explicitly, we need to
    include the relevant header as well.
    
    This fixes the following build error:
    
    	net/sunrpc/cache.c: In function 'cache_ioctl_procfs':
    	net/sunrpc/cache.c:1355: error: implicit declaration of function 'lock_kernel'
    	net/sunrpc/cache.c:1359: error: implicit declaration of function 'unlock_kernel'
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index 3212357..59ef938 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -28,6 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/mutex.h>
 #include <linux/pagemap.h>
+#include <linux/smp_lock.h>
 #include <asm/ioctls.h>
 #include <linux/sunrpc/types.h>
 #include <linux/sunrpc/cache.h>


--


[ message continues ]
Previous thread: Compat-wireless for 2.6.34 - 802.11 and bluetooth backported by Luis R. Rodriguez on Monday, April 12, 2010 - 9:51 pm. (2 messages)

Next thread: [PATCH] Staging: comedi: fix macros do - while loop and spaces before tabs issues in comedidev.h by Gustavo Silva on Monday, April 12, 2010 - 11:13 pm. (2 messages)