Home » Mailing list archives » linux-kernel » 2010 » April » 13

Re: [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface

Previous thread: [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib by michaelc on Monday, April 12, 2010 - 11:06 am. (4 messages)

Next thread: [PATCH][v2] Changes to more io-controller stats patches to address review comments. by Divyesh Shah on Monday, April 12, 2010 - 11:41 am. (5 messages)
[view original message]
From: michaelc
Subject: [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface
Date: Monday, April 12, 2010 - 11:06 am

From: Mike Christie <michaelc@cs.wisc.edu>

Not all iscsi drivers support ibft. For drivers like be2iscsi
that do not but are bootable through a vendor firmware specific
format/process this patch moves the sysfs interface from the ibft code
to a lib module. This then allows userspace tools to search for iscsi boot
info in a common place and in a common format.

ibft iscsi boot info is exported in the same place as it was
before: /sys/firmware/ibft.

vendor/fw boot info gets export in /sys/firmware/iscsi_bootX, where X is the
scsi host number of the HBA. Underneath these parent dirs, the
target, ethernet, and initiator dirs are the same as they were before.

This patch was made over the ibft-2.6 tree's ibft-1.03 branch:
http://git.kernel.org/?p=linux/kernel/git/konrad/ibft-2.6.git;a=shortlog;h=refs/heads/...


Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 drivers/firmware/Kconfig            |    8 +
 drivers/firmware/Makefile           |    1 +
 drivers/firmware/iscsi_boot_sysfs.c |  481 +++++++++++++++++++++++++++++++++++
 include/linux/iscsi_boot_sysfs.h    |  123 +++++++++
 4 files changed, 613 insertions(+), 0 deletions(-)
 create mode 100644 drivers/firmware/iscsi_boot_sysfs.c
 create mode 100644 include/linux/iscsi_boot_sysfs.h

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 1b03ba1..571d218 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -122,6 +122,14 @@ config ISCSI_IBFT_FIND
 	  is necessary for iSCSI Boot Firmware Table Attributes module to work
 	  properly.
 
+config ISCSI_BOOT_SYSFS
+	tristate "iSCSI Boot Sysfs Interface"
+	default	n
+	help
+	  This option enables support for exposing iSCSI boot information
+	  via sysfs to userspace. If you wish to export this information,
+	  say Y. Otherwise, say N.
+
 config ISCSI_IBFT
 	tristate "iSCSI Boot Firmware Table Attributes module"
 	depends on ISCSI_IBFT_FIND
diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
index ...
[ message continues ]
[view original message]
From: Konrad Rzeszutek Wilk
Subject: Re: [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface
Date: Monday, April 12, 2010 - 7:20 pm

Looks good to my eyes.

Let me run it tomorrow through my regression bucket before I stick on the git 
tree.
--


[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface
Date: Wednesday, August 11, 2010 - 8:54 am

Can we get this patch into linux-next, please?

or if it's there, there are still errors like this that need to be checked.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--


[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface
Date: Wednesday, August 11, 2010 - 9:04 am

Sorry, I replied to the (a) wrong email (thread).


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--


[ message continues ]
Previous thread: [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib by michaelc on Monday, April 12, 2010 - 11:06 am. (4 messages)

Next thread: [PATCH][v2] Changes to more io-controller stats patches to address review comments. by Divyesh Shah on Monday, April 12, 2010 - 11:41 am. (5 messages)