Re: LOCALVERSION_AUTO considered harmful

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Monday, April 12, 2010 - 10:03 am

On Mon, 12 Apr 2010, Pavel Machek wrote:


The problem is that you guys are looking at CONFIG_MODVERSIONS the wrong 
way around.

It's the _off_ case that is broken. Always was, always will be.

If CONFIG_MODVERSIONS is off, we remove the symbol versioning, and replace 
it with the _insane_ kernel version check. That is never valid. The fact 
that the kernel version is the same doesn't mean that the module will 
work, since we often do lots of changes within the same version.

So the solution is to say CONFIG_MODVERSIONS=y, and everybody is happy. 
Your modules will actually test things that _matter_, and will stop 
loading if the data types or function prototypes have changed. 

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
LOCALVERSION_AUTO considered harmful, Pavel Machek, (Sun Apr 11, 9:47 am)
Re: LOCALVERSION_AUTO considered harmful, Geert Uytterhoeven, (Sun Apr 11, 11:58 am)
Re: LOCALVERSION_AUTO considered harmful, Pavel Machek, (Sun Apr 11, 1:14 pm)
Re: LOCALVERSION_AUTO considered harmful, Thomas Gleixner, (Sun Apr 11, 3:24 pm)
Re: LOCALVERSION_AUTO considered harmful, rdunlap, (Sun Apr 11, 6:20 pm)
Re: LOCALVERSION_AUTO considered harmful, rdunlap, (Sun Apr 11, 7:56 pm)
Re: LOCALVERSION_AUTO considered harmful, Randy Dunlap, (Sun Apr 11, 8:49 pm)
Re: LOCALVERSION_AUTO considered harmful, Theodore Tso, (Mon Apr 12, 5:48 am)
Re: LOCALVERSION_AUTO considered harmful, Pavel Machek, (Mon Apr 12, 6:14 am)
Re: LOCALVERSION_AUTO considered harmful, Linus Torvalds, (Mon Apr 12, 10:03 am)
Re: LOCALVERSION_AUTO considered harmful, Alexey Dobriyan, (Mon Apr 12, 11:51 am)