Home » Mailing list archives » linux-kernel » 2010 » April » 12

Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its calling path

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Avi Kivity
Subject: Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its calling path
Date: Monday, April 12, 2010 - 5:49 am

On 04/12/2010 03:22 PM, Xiao Guangrong wrote:

Ouch.  I see now, thanks for explaining.

One way to fix it is to make kvm_mmu_zap_page() only zap the page it is 
given, and use sp->role.invalid on its children.  But it's better to fix 
it now quickly and do the more involved fixes later.

Just change the assignment to a 'goto restart;' please, I don't like 
playing with list_for_each internals.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/6] KVM MMU: remove unused struct, Xiao Guangrong, (Mon Apr 12, 12:59 am)
[PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its callin ..., Xiao Guangrong, (Mon Apr 12, 1:01 am)
[PATCH 3/6] KVM MMU: optimize/cleanup for marking parent u ..., Xiao Guangrong, (Mon Apr 12, 1:02 am)
[PATCH 4/6] KVM MMU: optimize for writing cr4, Xiao Guangrong, (Mon Apr 12, 1:03 am)
[PATCH 5/6] KVM MMU: reduce kvm_mmu_page size, Xiao Guangrong, (Mon Apr 12, 1:05 am)
[PATCH 6/6] KVM MMU: optimize synchronization shadow pages, Xiao Guangrong, (Mon Apr 12, 1:06 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Avi Kivity, (Mon Apr 12, 1:24 am)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Avi Kivity, (Mon Apr 12, 1:32 am)
Re: [PATCH 4/6] KVM MMU: optimize for writing cr4, Avi Kivity, (Mon Apr 12, 1:34 am)
Re: [PATCH 5/6] KVM MMU: reduce kvm_mmu_page size, Avi Kivity, (Mon Apr 12, 1:36 am)
Re: [PATCH 6/6] KVM MMU: optimize synchronization shadow pages, Avi Kivity, (Mon Apr 12, 1:43 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Xiao Guangrong, (Mon Apr 12, 1:53 am)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Xiao Guangrong, (Mon Apr 12, 1:55 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Avi Kivity, (Mon Apr 12, 2:08 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Xiao Guangrong, (Mon Apr 12, 2:22 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Avi Kivity, (Mon Apr 12, 3:25 am)
Re: [PATCH 4/6] KVM MMU: optimize for writing cr4, Xiao Guangrong, (Mon Apr 12, 3:42 am)
Re: [PATCH 5/6] KVM MMU: reduce kvm_mmu_page size, Xiao Guangrong, (Mon Apr 12, 4:11 am)
Re: [PATCH 6/6] KVM MMU: optimize synchronization shadow pages, Xiao Guangrong, (Mon Apr 12, 4:14 am)
Re: [PATCH 4/6] KVM MMU: optimize for writing cr4, Avi Kivity, (Mon Apr 12, 4:22 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Xiao Guangrong, (Mon Apr 12, 5:22 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Avi Kivity, (Mon Apr 12, 5:49 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Marcelo Tosatti, (Mon Apr 12, 10:10 am)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Marcelo Tosatti, (Mon Apr 12, 10:12 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Xiao Guangrong, (Mon Apr 12, 6:34 pm)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Xiao Guangrong, (Mon Apr 12, 6:53 pm)
Re: [PATCH 4/6] KVM MMU: optimize for writing cr4, Xiao Guangrong, (Mon Apr 12, 8:07 pm)
Re: [PATCH 4/6] KVM MMU: optimize for writing cr4, Avi Kivity, (Mon Apr 12, 11:42 pm)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Avi Kivity, (Tue Apr 13, 4:58 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Marcelo Tosatti, (Tue Apr 13, 7:59 am)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Marcelo Tosatti, (Tue Apr 13, 8:01 am)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Xiao Guangrong, (Tue Apr 13, 7:14 pm)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Xiao Guangrong, (Tue Apr 13, 8:23 pm)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Xiao Guangrong, (Tue Apr 13, 8:58 pm)
Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its ca ..., Marcelo Tosatti, (Wed Apr 14, 9:31 am)
Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking pare ..., Marcelo Tosatti, (Wed Apr 14, 9:35 am)