Home » Mailing list archives » linux-kernel » 2010 » April » 1

Re: [PATCH] Fix missing of last user info while getting DEBUG_SLAB config enabled

Previous thread: linux-next: Tree for April 1 by Stephen Rothwell on Wednesday, March 31, 2010 - 11:23 pm. (5 messages)

Next thread: [GIT PULL] arch/microblaze fixes for 2.6.34-rc4 by Michal Simek on Wednesday, March 31, 2010 - 11:49 pm. (1 message)
[view original message]
From: Pekka Enberg
Subject: Re: [PATCH] Fix missing of last user info while getting DEBUG_SLAB config enabled
Date: Wednesday, March 31, 2010 - 11:29 pm

I don't understand what you're trying to do here. What if align is less 
han sizeof(unsigned long long)? What if SLAB_RED_ZONE is not enabled but 
  SLAB_STORE_USER is?

			Pekka
--


[ message continues ]
[view original message]
From: TAO HU
Subject: Re: [PATCH] Fix missing of last user info while getting DEBUG_SLAB config enabled
Date: Thursday, April 1, 2010 - 12:08 am

Hi, Pekka

Thanks for your feedback.

The subject and comments are kind of misleading. Sorry about that.
It intends to make  both Red-Zone and LastUser are available even the
alignment is larger than sizeof(long long).
The idea is to reserve certain room ("align") to let the obj's offset
is aligned to cache-line-size to address requirement of kmalloc().

Regarding align is less than sizeof(unsigned long long), I thin it is
handled in previous code.
Or you still expect to explicitly let align is no less than
sizeof(unsigned long long)?
if (flags & SLAB_RED_ZONE) {
                ralign = REDZONE_ALIGN;
             ... ...
        }


-- 
Best Regards
Hu Tao

--


[ message continues ]
Previous thread: linux-next: Tree for April 1 by Stephen Rothwell on Wednesday, March 31, 2010 - 11:23 pm. (5 messages)

Next thread: [GIT PULL] arch/microblaze fixes for 2.6.34-rc4 by Michal Simek on Wednesday, March 31, 2010 - 11:49 pm. (1 message)