[PATCH -v4 2/2] bootmem, x86: Fix 32bit numa system without RAM on Node0

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Wednesday, March 31, 2010 - 8:45 pm

When 32bit numa is used, free_all_bootmem() will still only go over with
node id 0.

If node 0 doesn't have RAM installed, We need to go with node1
because early_node_map still use 1 for all ranges, and ram from node1
become low ram.

this one fixes BOOTMEM path by loop bdata_list.

-v3: add more comments, and fix bootmem path too.
-v4: seperate from one big patch

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 mm/bootmem.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Index: linux-2.6/mm/bootmem.c
===================================================================
--- linux-2.6.orig/mm/bootmem.c
+++ linux-2.6/mm/bootmem.c
@@ -312,7 +312,13 @@ unsigned long __init free_all_bootmem(vo
 	 */
 	return free_all_memory_core_early(MAX_NUMNODES);
 #else
-	return free_all_bootmem_core(NODE_DATA(0)->bdata);
+	unsigned long total_pages = 0;
+	bootmem_data_t *bdata;
+
+	list_for_each_entry(bdata, &bdata_list, list)
+		total_pages += free_all_bootmem_core(bdata);
+
+	return total_pages;
 #endif
 }
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Config NO_BOOTMEM breaks my amd64 box, James Morris, (Tue Mar 30, 9:49 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Tue Mar 30, 11:26 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Tue Mar 30, 11:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Stefan Richter, (Wed Mar 31, 3:51 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 9:25 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 11:59 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Wed Mar 31, 1:57 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Linus Torvalds, (Wed Mar 31, 2:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Wed Mar 31, 2:14 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 2:40 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 2:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:05 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:13 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:16 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 3:28 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:41 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:56 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 3:58 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 4:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:34 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:35 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 4:43 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:48 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 4:54 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Johannes Weiner, (Wed Mar 31, 5:01 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 5:35 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 6:00 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 6:07 pm)
[PATCH -v4 2/2] bootmem, x86: Fix 32bit numa system withou ..., Yinghai Lu, (Wed Mar 31, 8:45 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 1, 5:52 am)
[tip:x86/urgent] nobootmem, x86: Fix 32bit numa system wit ..., tip-bot for Yinghai Lu, (Thu Apr 1, 3:57 pm)
[tip:x86/urgent] bootmem, x86: Fix 32bit numa system witho ..., tip-bot for Yinghai Lu, (Thu Apr 1, 3:57 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Apr 7, 11:32 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai, (Thu Apr 8, 12:00 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 8, 12:27 am)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Thu Apr 8, 1:05 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 8, 1:22 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Thu Apr 8, 7:43 pm)