Hi Arnd,
Looking at your tree, I see you have commit 753dd249 ("perf_event: use
nonseekable_open") that does:
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -2515,6 +2515,8 @@ static int perf_fasync(int fd, struct file *filp, int on)
> }
>
> static const struct file_operations perf_fops = {
> + .open = nonseekable_open,
> + .llseek = no_llseek,
> .release = perf_release,
> .read = perf_read,
> .poll = perf_poll,
But if I understand this correctly, the assignment to .open is at best
useless -- these file_operations are only used via anon_inode_getfd()
and so there is no possible path that can call the .open method. Or am
I missing something?
(The same applies to the kvm_main.c changes too)
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--