Re: Config NO_BOOTMEM breaks my amd64 box

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Wednesday, March 31, 2010 - 3:05 pm

On 03/30/2010 11:47 PM, James Morris wrote:

in case, you have one 32bit system without RAM installed on node0. please check

Thanks

Yinghai

Subject: [PATCH] x86: Fix 32bit system without RAM on Node0

when 32bit numa is used, free_all_bootmem() will still only go over with
node id 0.

If node 0 doesn't have RAM installed, We need to go with node1
because early_node_map still use 1 for all ranges, and ram from node1
becom low ram.

Try to use MAX_NUMNODES like 64 numa does.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/mm/init_32.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux-2.6/arch/x86/mm/init_32.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/init_32.c
+++ linux-2.6/arch/x86/mm/init_32.c
@@ -875,7 +875,12 @@ void __init mem_init(void)
 	BUG_ON(!mem_map);
 #endif
 	/* this will put all low memory onto the freelists */
+#if defined(CONFIG_NO_BOOTMEM) && defined(MAX_NUMNODES)
+	/* In case some 32bit systems don't have RAM installed on node0 */
+        totalram_pages += free_all_memory_core_early(MAX_NUMNODES);
+#else
 	totalram_pages += free_all_bootmem();
+#endif
 
 	reservedpages = 0;
 	for (tmp = 0; tmp < max_low_pfn; tmp++)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Config NO_BOOTMEM breaks my amd64 box, James Morris, (Tue Mar 30, 9:49 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Tue Mar 30, 11:26 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Tue Mar 30, 11:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Stefan Richter, (Wed Mar 31, 3:51 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 9:25 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 11:59 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Wed Mar 31, 1:57 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Linus Torvalds, (Wed Mar 31, 2:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Wed Mar 31, 2:14 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 2:40 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 2:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:05 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:13 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:16 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 3:28 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:41 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 3:47 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 3:56 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 3:58 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Mar 31, 4:02 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:34 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:35 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 4:43 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 4:48 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 4:54 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Johannes Weiner, (Wed Mar 31, 5:01 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, H. Peter Anvin, (Wed Mar 31, 5:35 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Wed Mar 31, 6:00 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai Lu, (Wed Mar 31, 6:07 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 1, 5:52 am)
[tip:x86/urgent] nobootmem, x86: Fix 32bit numa system wit ..., tip-bot for Yinghai Lu, (Thu Apr 1, 3:57 pm)
[tip:x86/urgent] bootmem, x86: Fix 32bit numa system witho ..., tip-bot for Yinghai Lu, (Thu Apr 1, 3:57 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Wed Apr 7, 11:32 pm)
Re: Config NO_BOOTMEM breaks my amd64 box, Yinghai, (Thu Apr 8, 12:00 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 8, 12:27 am)
Re: Config NO_BOOTMEM breaks my amd64 box, James Morris, (Thu Apr 8, 1:05 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Ingo Molnar, (Thu Apr 8, 1:22 am)
Re: Config NO_BOOTMEM breaks my amd64 box, Dave Airlie, (Thu Apr 8, 7:43 pm)