Re: [PATCH] fat: fix buffer overflow in vfat_create_shortname()

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Nikolaus Schulz

Subject: Re: [PATCH] fat: fix buffer overflow in vfat_create_shortname()

Date: Wednesday, March 31, 2010 - 5:08 am

On Thu, Mar 25, 2010 at 09:52:12PM +0900, OGAWA Hirofumi wrote:
quoted text> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> > Nikolaus Schulz <microschulz@web.de> writes:
> >
> >>> However, anyway, your patch is much better off than current one. So,
> >>> I'll apply this in the next merge window.
> >>> 
> >>> Or should we apply this immediately?
> >>> 
> >>> Thanks.
> >>
> >> Given that this fixes a stack corruption which triggers the gcc stack
> >> smashing protection and thus basically a crash, I vote for not
> >> postponing it, but applying it immediately.
> >
> > Um..., where is a stack corruption? sprintf() overflow? But, it's
> > actually snprintf(), not sprintf()...
> 
> Whoops, it was really sprintf().

Ping?

I really think this should go into 2.6.34 and the next stable kernel
updates.

Nikolaus
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] fat: fix buffer overflow in vfat_create_shortname(), Nikolaus Schulz, (Wed Mar 24, 8:50 pm)

Re: [PATCH] fat: fix buffer overflow in vfat_create_shortn ..., OGAWA Hirofumi, (Wed Mar 24, 10:30 pm)

Re: [PATCH] fat: fix buffer overflow in vfat_create_shortn ..., Nikolaus Schulz, (Thu Mar 25, 5:24 am)

Re: [PATCH] fat: fix buffer overflow in vfat_create_shortn ..., OGAWA Hirofumi, (Thu Mar 25, 5:33 am)

Re: [PATCH] fat: fix buffer overflow in vfat_create_shortn ..., OGAWA Hirofumi, (Thu Mar 25, 5:52 am)

Re: [PATCH] fat: fix buffer overflow in vfat_create_shortn ..., Nikolaus Schulz, (Wed Mar 31, 5:08 am)

[PATCH] fat: fix buffer overflow in vfat_create_shortname(), OGAWA Hirofumi, (Wed Mar 31, 10:21 am)

Navigation

Popular discussions


linux-kernel:
Stephen Smalley	Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching
Paul Gortmaker	[34-longterm 237/260] KVM: x86: Move TSC reset out of vmcb_init
Mathieu Desnoyers	Re: Linux 2.6.25-rc2
Luben Tuikov	Re: Integration of SCST in the mainstream Linux kernel
Borislav Petkov	drm_vm.c:drm_mmap: possible circular locking dependency detected (was: Re: Linux 2...
git:
Mike Miller	git message
Wincent Colaiuta	Re: [RFC PATCH] Make the rebase edit mode really end up in an edit state
Johannes Schindelin	Re: [PATCH] Fix install-doc-quick target
Kevin Ballard	Re: git check-attr -z and quoting
Dan Chokola	Re: how do you "force a pull"?
git-commits-head:
Linux Kernel Mailing List	mm: fix build on non-mmu machines
Linux Kernel Mailing List	ALSA: hda: Use olpc-xo-1_5 quirk for Toshiba Satellite P500-PSPGSC-01800T
Linux Kernel Mailing List	powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List	Staging: rt2870: Removal of kernel_thread() API
Linux Kernel Mailing List	NFSv4: Move error handling out of the delegation generic code
linux-netdev:
Arnaldo Carvalho de Melo	Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Sebastian Andrzej Siewior	[PATCH v2] net/core: use ntohs for skb->protocol
Badalian Vyacheslav	Re: tc filter flow hash question
Parav Pandit	ip6 route output() and ip_route_output_key() by drivers
Jarek Poplawski	Re: tc filter flow hash question
openbsd-misc:
Tony Abernethy	Re: The Atheros story in much fewer words
ropers	Re: Real men don't attack straw men
"RALOVICH, Kristóf"	Re: thinkpad windows refund
Kevin	Re: uvm_mapent_alloc: out of static map entries on 4.3 i386
Nick Holland	Re: Install OpenBSD from USB ?

Colocation donated by:

Syndicate