[PATCH] FS-Cache: Order the debugfs stats correctly

Previous thread: Linux 2.6.34-rc3 by Linus Torvalds on Tuesday, March 30, 2010 - 10:50 am. (231 messages)

Next thread: [PATCH] ARM: pcmcia: Adds nanoEngine PCMCIA support. by Marcelo Roberto Jimenez on Tuesday, March 30, 2010 - 11:14 am. (5 messages)
From: David Howells
Date: Tuesday, March 30, 2010 - 11:02 am

Order the debugfs statistics correctly.  The values displayed through a
seq_printf() statement should be in the same order as the names in the format
string.

In the 'Lookups' line, objects created ('crt=') and lookups timed out ('tmo=')
have their values transposed.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/fscache/stats.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fscache/stats.c b/fs/fscache/stats.c
index 46435f3..4765190 100644
--- a/fs/fscache/stats.c
+++ b/fs/fscache/stats.c
@@ -165,8 +165,8 @@ static int fscache_stats_show(struct seq_file *m, void *v)
 		   atomic_read(&fscache_n_object_lookups),
 		   atomic_read(&fscache_n_object_lookups_negative),
 		   atomic_read(&fscache_n_object_lookups_positive),
-		   atomic_read(&fscache_n_object_lookups_timed_out),
-		   atomic_read(&fscache_n_object_created));
+		   atomic_read(&fscache_n_object_created),
+		   atomic_read(&fscache_n_object_lookups_timed_out));
 
 	seq_printf(m, "Updates: n=%u nul=%u run=%u\n",
 		   atomic_read(&fscache_n_updates),

--

Previous thread: Linux 2.6.34-rc3 by Linus Torvalds on Tuesday, March 30, 2010 - 10:50 am. (231 messages)

Next thread: [PATCH] ARM: pcmcia: Adds nanoEngine PCMCIA support. by Marcelo Roberto Jimenez on Tuesday, March 30, 2010 - 11:14 am. (5 messages)