Home » Mailing list archives » linux-kernel » 2010 » March » 30

[PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock

Previous thread: [PATCH] Fix staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop by Jonathan Cameron on Tuesday, March 30, 2010 - 9:45 am. (1 message)

Next thread: [PATCH] increase PREEMPT_BITS to 12 to avoid overflow when starting KVM by Rik van Riel on Tuesday, March 30, 2010 - 10:36 am. (43 messages)
[view original message]
From: Oleg Nesterov
Subject: [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock
Date: Tuesday, March 30, 2010 - 9:58 am

Trivial typo fix. rq->migration_thread can be NULL after task_rq_unlock(),
this is why we have "mt" which should be used instead.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

 sched.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 34-rc1/kernel/sched.c~S_C_A_P_USE_MT	2010-03-29 19:46:21.000000000 +0200
+++ 34-rc1/kernel/sched.c	2010-03-30 18:52:05.000000000 +0200
@@ -5365,7 +5365,7 @@ int set_cpus_allowed_ptr(struct task_str
 
 		get_task_struct(mt);
 		task_rq_unlock(rq, &flags);
-		wake_up_process(rq->migration_thread);
+		wake_up_process(mt);
 		put_task_struct(mt);
 		wait_for_completion(&req.done);
 		tlb_migrate_finish(p->mm);

--


[ message continues ]
[view original message]
From: Peter Zijlstra
Subject: Re: [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock
Date: Tuesday, March 30, 2010 - 10:15 am

Thanks!

--


[ message continues ]
[view original message]
From: tip-bot for Oleg Nesterov
Subject: [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't use rq->migration_thread after unlock
Date: Friday, April 2, 2010 - 12:10 pm

Commit-ID:  47a70985e5c093ae03d8ccf633c70a93761d86f2
Gitweb:     http://git.kernel.org/tip/47a70985e5c093ae03d8ccf633c70a93761d86f2
Author:     Oleg Nesterov <oleg@redhat.com>
AuthorDate: Tue, 30 Mar 2010 18:58:29 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 2 Apr 2010 20:11:05 +0200

sched: set_cpus_allowed_ptr(): Don't use rq->migration_thread after unlock

Trivial typo fix. rq->migration_thread can be NULL after
task_rq_unlock(), this is why we have "mt" which should be
 used instead.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100330165829.GA18284@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 49d2fa7..528a105 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5387,7 +5387,7 @@ int set_cpus_allowed_ptr(struct task_struct *p, const struct cpumask *new_mask)
 
 		get_task_struct(mt);
 		task_rq_unlock(rq, &flags);
-		wake_up_process(rq->migration_thread);
+		wake_up_process(mt);
 		put_task_struct(mt);
 		wait_for_completion(&req.done);
 		tlb_migrate_finish(p->mm);
--


[ message continues ]
Previous thread: [PATCH] Fix staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop by Jonathan Cameron on Tuesday, March 30, 2010 - 9:45 am. (1 message)

Next thread: [PATCH] increase PREEMPT_BITS to 12 to avoid overflow when starting KVM by Rik van Riel on Tuesday, March 30, 2010 - 10:36 am. (43 messages)