Re: [PATCH 4/6] procfs: Use generic_file_llseek in /proc/vmcore | KernelTrap

Re: [PATCH 4/6] procfs: Use generic_file_llseek in /proc/vmcore

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Arnd Bergmann

Subject: Re: [PATCH 4/6] procfs: Use generic_file_llseek in /proc/vmcore

Date: Tuesday, March 30, 2010 - 3:38 am

On Tuesday 30 March 2010, Frederic Weisbecker wrote:
quoted text> /proc/vmcore has no llseek and then falls down to use default_llseek.
> This is racy against read_vmcore() that directly manipulates fpos
> but it doesn't hold the bkl there so using it in llseek doesn't
> protect anything.
> 
> Let's use generic_file_llseek() instead.
> 
Acked-by: Arnd Bergmann <arnd@arndb.de>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/6] Kill the bkl in procfs, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 1/6] procfs: Kill BKL in llseek on proc base, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 2/6] procfs: Use generic_file_llseek in /proc/kcore, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 3/6] procfs: Use generic_file_llseek in /proc/kmsg, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 4/6] procfs: Use generic_file_llseek in /proc/vmcore, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 5/6] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

[PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Mon Mar 29, 11:20 pm)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Alexey Dobriyan, (Mon Mar 29, 11:31 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Alexey Dobriyan, (Mon Mar 29, 11:38 pm)

Re: [PATCH 1/6] procfs: Kill BKL in llseek on proc base, Alexey Dobriyan, (Mon Mar 29, 11:40 pm)

Re: [PATCH 1/6] procfs: Kill BKL in llseek on proc base, Frederic Weisbecker, (Mon Mar 29, 11:50 pm)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Tue Mar 30, 12:02 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Tue Mar 30, 12:07 am)

Re: [PATCH 2/6] procfs: Use generic_file_llseek in /proc/kcore, Arnd Bergmann, (Tue Mar 30, 3:28 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Tue Mar 30, 3:33 am)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Arnd Bergmann, (Tue Mar 30, 3:37 am)

Re: [PATCH 4/6] procfs: Use generic_file_llseek in /proc/v ..., Arnd Bergmann, (Tue Mar 30, 3:38 am)

Re: [PATCH 3/6] procfs: Use generic_file_llseek in /proc/kmsg, Arnd Bergmann, (Tue Mar 30, 3:38 am)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Tue Mar 30, 11:27 am)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Arnd Bergmann, (Tue Mar 30, 11:54 am)

Re: [PATCH 5/6] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Tue Mar 30, 12:21 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Wed Mar 31, 10:22 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Wed Mar 31, 1:21 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Wed Mar 31, 2:04 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Wed Mar 31, 2:41 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Alan Cox, (Wed Mar 31, 2:55 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Wed Mar 31, 2:56 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Thu Apr 1, 2:07 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Thu Apr 1, 4:37 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Stefan Richter, (Thu Apr 1, 4:39 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Thu Apr 1, 5:42 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Thu Apr 1, 5:45 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Stefan Richter, (Sat Apr 3, 10:53 am)

[PATCH v2] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Fri Apr 9, 7:45 am)

[PATCH v3] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Sat Apr 10, 6:25 am)

Re: [PATCH 0/6] Kill the bkl in procfs, Frederic Weisbecker, (Sat Apr 10, 6:27 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Sat Apr 10, 8:28 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Sat Apr 10, 9:09 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Sat Apr 10, 9:14 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Sat Apr 10, 9:24 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Christoph Hellwig, (Sun Apr 11, 6:03 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Mon Apr 12, 8:05 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Mon Apr 12, 10:34 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Mon Apr 12, 2:53 pm)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Arnd Bergmann, (Tue Apr 13, 2:26 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Christoph Hellwig, (Tue Apr 13, 11:03 am)

Re: [PATCH 6/6] procfs: Kill the bkl in ioctl, Frederic Weisbecker, (Tue Apr 13, 1:10 pm)

[PATCH v4] procfs: Push down the bkl from ioctl, Frederic Weisbecker, (Sun May 16, 6:23 pm)

Navigation

Popular discussions


linux-kernel:
Ingo Molnar	Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge	Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin	Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade	Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson	Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev:
Arnd Bergmann	Re: 64-bit net_device_stats
Stephens, Allan	RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka	[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang	Re: [PATCH] dm9601: handle corrupt mac address
David Miller	Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git:
Junio C Hamano	Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano	Re: Handling large files with GIT
Karl	Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett	Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit	Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head:
Linux Kernel Mailing List	MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List	regulator: update email address for Liam Girdwood
Linux Kernel Mailing List	[SCSI] ipr: add message to error table
Linux Kernel Mailing List	powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List	USB: omap_udc: sync with OMAP tree
openbsd-misc:
Josh Grosse	Re: error : pkg add phpMyAdmin
Brian Candler	Re: OBSD's perspective on SELinux
Jacob Meuser	Re: /dev/audio: Device busy
David Vasek	Re: Inexpensive, low power, "wall wart" computer
William Boshuck	Re: Richard Stallman...

Colocation donated by:

Syndicate