login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
March
»
26
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_times() can race with getrusage()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Stanislaw Gruszka
Subject:
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_times() can race with getrusage()
Date: Friday, March 26, 2010 - 12:37 am
On Fri, Mar 26, 2010 at 09:23:44AM +0530, Balbir Singh wrote:
quoted text
> * Oleg Nesterov <oleg@redhat.com> [2010-03-24 21:45:50]: > > > do_task_stat()->task_times() can race with getrusage(), they both can > > try to update task->prev_Xtime at the same time. > > > > Remove this bit of d180c5bc "sched: Introduce task_times() to replace > > task_{u,s}time()". > > One of the reasons for adding this accuracy was to avoid sampling > based noise and errors that occur with utime and stime. > > As long as there is no preemption during the assignment, I think we > should be OK. > > I see two options > > 1. Disable preemption around assignment
That one sounds very good.
quoted text
> 2. Remove task_times() from getrusage()
We want more accurate and what more important monotonic values in getrusage. Stanislaw --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_times ...
, Oleg Nesterov
, (Wed Mar 24, 1:45 pm)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Balbir Singh
, (Thu Mar 25, 8:53 pm)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Stanislaw Gruszka
, (Fri Mar 26, 12:37 am)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Stanislaw Gruszka
, (Fri Mar 26, 9:12 am)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Oleg Nesterov
, (Fri Mar 26, 2:49 pm)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Stanislaw Gruszka
, (Mon Mar 29, 4:17 am)
Re: [RFC,PATCH 1/2] cputimers/proc: do_task_stat()->task_t ...
, Oleg Nesterov
, (Mon Mar 29, 5:54 am)
[PATCH -mm 0/4] cputimers/proc: do_task_stat: don't walk t ...
, Oleg Nesterov
, (Mon Mar 29, 11:12 am)
[PATCH -mm 1/4] cputimers: thread_group_cputime: cleanup r ...
, Oleg Nesterov
, (Mon Mar 29, 11:12 am)
[PATCH -mm 2/4] cputimers: make sure thread_group_cputime( ...
, Oleg Nesterov
, (Mon Mar 29, 11:13 am)
[PATCH -mm 3/4] cputimers: thread_group_times: make it rcu ...
, Oleg Nesterov
, (Mon Mar 29, 11:13 am)
[PATCH -mm 1/4] cputimers: do_task_stat: avoid ->siglock f ...
, Oleg Nesterov
, (Mon Mar 29, 11:14 am)
Re: [PATCH -mm 1/4] cputimers: do_task_stat: avoid ->siglo ...
, Oleg Nesterov
, (Mon Mar 29, 11:16 am)
Re: [PATCH -mm 2/4] cputimers: make sure thread_group_cput ...
, Stanislaw Gruszka
, (Tue Mar 30, 4:01 am)
Re: [PATCH -mm 2/4] cputimers: make sure thread_group_cput ...
, Oleg Nesterov
, (Tue Mar 30, 6:43 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rusty Russell
Re: 2.6.22-rc3-mm1
Gautham R Shenoy
[PATCH 1/8] Enhance process freezer interface for usage beyond software suspend
Srivatsa Vaddagiri
Re: [PATCH 7/8] Clean up workqueue.c with respect to the freezer based cpu-hotplug
Nicholas A. Bellinger
Re: [Scst-devel] Fwd: Re: linuxcon 2010...
Jeffrey V. Merkey
Re: Versioning file system
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List
OMAP: DSS2: SDI driver
Linux Kernel Mailing List
PCI: introduce pci_pcie_cap()
Linux Kernel Mailing List
ipc/sem.c: move wake_up_process out of the spinlock section
Linux Kernel Mailing List
netfilter: nf_conntrack_sip: add T.38 FAX support
git
:
Oliver Kullmann
Re: how to move with history?
Junio C Hamano
Re: [PATCH 2/3] git-add--interactive: remove hunk coalescing
Shawn O. Pearce
Re: Bugs in Gitosis
Miles Bader
Re: way to automatically add untracked files?
Torgil Svensson
Re: [RFC] Submodules in GIT
linux-netdev
:
Timo Teräs
ip xfrm policy semantics
David Miller
Re: [2.6.30-rc3] powerpc: compilation error of mace module
Patrick McHardy
Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
webmaster Maintenance
&#32852;&#31995;&#31995;&#32479;&#31649;&#29702;&#21592;
Krzysztof Oledzki
Re: Error: an inet prefix is expected rather than "0/0".
openbsd-misc
:
Ted Bullock
Re: Proliant DL380 G3 cannot get on network
Úlfar M. E. Johnson
installing openbsd in xen
Eric Furman
Re: Defending OpenBSD Performance
Tony Abernethy
Re: The Atheros story in much fewer words
Damien Miller
Re: Patching a SSH 'Weakness'
Colocation donated by:
Syndicate