Re: [PATCH 1/2] DMAENGINE: generic slave control

Previous thread: [PATCH 2/2] DMAENGINE: generic channel status by Linus Walleij on Thursday, March 25, 2010 - 8:03 am. (7 messages)

Next thread: Missing BLKPG functions by Phillip Susi on Thursday, March 25, 2010 - 8:04 am. (1 message)
From: Linus Walleij
Date: Thursday, March 25, 2010 - 8:02 am

Convert the device_terminate_all() operation on the
DMA engine to a generic device_control() operation
which can now optionally support also pausing and
resuming DMA on a certain channel. Implemented for the
COH 901 318 DMAC as an example.

Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Li Yang <leoli@freescale.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Magnus Damm <damm@opensource.se>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-u300/include/mach/coh901318.h |   14 ---------
 drivers/dma/at_hdmac.c                      |   10 +++++-
 drivers/dma/coh901318.c                     |   42 ++++++++++++++++++---------
 drivers/dma/dmaengine.c                     |    2 +-
 drivers/dma/dw_dmac.c                       |   10 +++++-
 drivers/dma/fsldma.c                        |   11 ++++++-
 drivers/dma/ipu/ipu_idmac.c                 |   19 ++++++++----
 drivers/dma/shdma.c                         |   10 +++++-
 drivers/dma/txx9dmac.c                      |   10 +++++-
 drivers/mmc/host/atmel-mci.c                |    2 +-
 drivers/serial/sh-sci.c                     |    2 +-
 drivers/video/mx3fb.c                       |    3 +-
 include/linux/dmaengine.h                   |   18 ++++++++++-
 sound/soc/txx9/txx9aclc.c                   |    6 ++--
 14 files changed, 106 insertions(+), 53 deletions(-)

diff --git a/arch/arm/mach-u300/include/mach/coh901318.h b/arch/arm/mach-u300/include/mach/coh901318.h
index b8155b4..43ec040 100644
--- a/arch/arm/mach-u300/include/mach/coh901318.h
+++ b/arch/arm/mach-u300/include/mach/coh901318.h
@@ -110,20 +110,6 @@ struct coh901318_platform {
 u32 coh901318_get_bytes_left(struct dma_chan ...
From: Dan Williams
Date: Thursday, March 25, 2010 - 4:30 pm

I'd prefer ENXIO here since it may be a valid command, just not
implemented in this specific driver.

Here is the important bits from build_dma.sh:

drivers/dma/ipu/ipu_idmac.c: In function '__idmac_control':
drivers/dma/ipu/ipu_idmac.c:1512: warning: control reaches end of non-void function
drivers/dma/fsldma.c: In function 'fsl_dma_device_control':
drivers/dma/fsldma.c:788: warning: 'return' with no value, in function returning non-void
drivers/dma/ppc4xx/adma.c:3944: error: expected identifier or '(' before '{' token
drivers/dma/shdma.c: In function `sh_dmae_control':
drivers/dma/shdma.c:592: warning: `return' with no value, in function returning non-void

--
Dan


--

Previous thread: [PATCH 2/2] DMAENGINE: generic channel status by Linus Walleij on Thursday, March 25, 2010 - 8:03 am. (7 messages)

Next thread: Missing BLKPG functions by Phillip Susi on Thursday, March 25, 2010 - 8:04 am. (1 message)