Re: [PATCH -mm 1/1] proc: turn signal_struct->count into "int nr_threads"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Oleg Nesterov
Date: Wednesday, March 24, 2010 - 11:12 am

On 03/24, Oleg Nesterov wrote:

Argh, I forgot to send "[PATCH 0/1]", please see below...


[PATCH -mm 0/1] proc: turn signal_struct->count into "int nr_threads"

Depends on

	[PATCH -mm 1/2] proc_sched_show_task: use get_nr_threads()
	[PATCH -mm 2/2] keyctl_session_to_parent: use thread_group_empty() to check singlethreadness

and on top of the trivial

	[PATCH -mm] signals-clear-signal-tty-when-the-last-thread-exits.fix

I did "make allyesconfig" to test this change, but the compilation
failed because of unrelated bugs, and of course "count" is not really
grepable :/

However,

	$ grep -nr --include=*.[ch] -E 'sig\w*->count' */ | grep -Ev 'sigh(and)?->count'
	kernel/fork.c:827:	atomic_set(&sig->count, 1);

and this "sig" above is in fact sighand.

Fortunately, if I missed some user of signal->count the necessary fix
will be really trivial. And I bet in this case that user should be
wrong anyway.

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH -mm 1/1] proc: turn signal_struct->count into " ..., Oleg Nesterov, (Wed Mar 24, 11:12 am)