Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h from iwl-devtrace.h

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: reinette chatre

Subject: Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h from iwl-devtrace.h

Date: Wednesday, March 24, 2010 - 10:55 am

On Wed, 2010-03-24 at 01:48 -0700, Tejun Heo wrote:
quoted text> iwl-devtrace.h is used to declare and define trace points and
> including iwl-dev.h from the file, which in turn includes other
> generic headers can lead to problems like generating duplicate copies
> of generic trace points depending on the order of includes.  Don't
> include iwl-dev.h from iwl-devtrace.h but include it from its users -
> iwl-io.h and iwl-devtrace.c.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Zhu Yi <yi.zhu@intel.com>
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Intel Linux Wireless <ilw@linux.intel.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> ---

Thank you

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCHSET] remove implicit slab.h inclusion from from percpu.h, Tejun Heo, (Wed Mar 24, 1:48 am)

[PATCH 2/4] iwlwifi: don't include iwl-dev.h from iwl-devt ..., Tejun Heo, (Wed Mar 24, 1:48 am)

[PATCH 3/4] include cleanup: Update gfp.h and slab.h inclu ..., Tejun Heo, (Wed Mar 24, 1:48 am)

[PATCH 4/4] percpu: don't implicitly include slab.h from p ..., Tejun Heo, (Wed Mar 24, 1:48 am)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Pekka Enberg, (Wed Mar 24, 4:00 am)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Alexey Dobriyan, (Wed Mar 24, 4:57 am)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Tejun Heo, (Wed Mar 24, 6:33 am)

Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h from iwl- ..., reinette chatre, (Wed Mar 24, 10:55 am)

Re: [PATCH 4/4] percpu: don't implicitly include slab.h fr ..., Christoph Lameter, (Wed Mar 24, 12:23 pm)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Christoph Lameter, (Wed Mar 24, 12:42 pm)

Re: [PATCHSET] remove implicit slab.h inclusion from from ..., Tejun Heo, (Sun Mar 28, 5:50 pm)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Lee Schermerhorn, (Tue Mar 30, 7:30 am)

Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h i ..., Tejun Heo, (Tue Mar 30, 7:41 pm)


linux-kernel:
Michael Trimarchi	Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi	[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn	Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai	[PATCH 2/2] input: Add LED support to Synaptics device
git:
Junio C Hamano	Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen	Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce	Re: Switching from CVS to GIT
Todd Zullinger	Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar	Re: How to use git-fmt-merge-msg?
linux-netdev:
Ramkrishna Vepa	[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony	invitation / inquiry
Ingo Molnar	Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller	Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer	[PATCH 03/12] fec: do not typedef struct types
git-commits-head:
Linux Kernel Mailing List	amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List	MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List	ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List	davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List	x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc:
Daniel A. Ramaley	Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian	Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer	Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther	Re: SIGCHLD and libpthread.so
J.C. Roberts	Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?