Re: [PATCH 06/20] early_res: seperate common memmap func from e820.c to fw_memmap.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Tuesday, March 23, 2010 - 4:16 am

* Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:


As an upstream maintainer i mainly care about upstream kernel contributions. 
These contributions have three main forms:

  - patches i get against latest upstream

  - on-lkml review/analysis that is done on those patches

  - test/bug/regression reports i get against latest upstream (either directly 
    on lkml or via kerneloops.org or bugzilla.kernel.org)

So i weigh the architectures based on that input.

Since you mentioned ARM - here's the Git contribution stats. In the last 5 
years since we have kernel Git history, there's been 1080 commits to 
kernel/sched.c. Amongst those 1080 commits i could find only a _single commit_ 
(a minor fix) being related to or contributed by anyone doing ARM development!

To be on the safe side lets assume that i missed many commits, lets up that 
count to ten times of that count: 10 commits. I.e. the 'weight of ARM', when 
it comes to kernel/sched.c, is still less than 1%.
 
'millions of ARM units' alone means little to me, if it does not translate 
into actual upstream kernel contributions. Many of those 'millions of units' 
are walled off from kernel contributions: the users dont even know they are 
running Linux. They are not linked to kerneloops.org and dont produce bugzilla 
bugreports. They do finance Linux developers by proxy - but as far as the 
upstream kernel is concerned they only exist to the extent they finance kernel 
developers to care about it.

Lets look at a counter example: Sparc64. There's literally just a handful of 
Sparc64 'units' that run Linux, still the weight of the arch is much higher - 
due to the well-known highly productive kernel contributor who is using that 
architecture. I have seen about 10 times more scheduler contributions [~15 
commits] from that single unit Sparc64 angle than from the millions of ARM 
units! (and davem isnt even doing scheduler development per se - he's mostly 
doing drive-by fixes and improvements with no particular focus on the 
scheduler.)

Or lets look at an architecture that during its development had a physical 
unit count of _zero_: SGI UV. It was only running in simulators for a year but 
it sure resulted in dozens and dozens of useful patches that extended Linux's 
scalability reach. So did SGI UV matter, despite having had a zero unit count? 
Heck it did ...

I singled out kernel/sched.c but there's a very similar picture and 
contribution weights when it comes to other areas i co-maintain: lockdep, 
perf, tracing, etc.

So if you want your architecture to matter to me the rule is very simple: 
contribute, contribute, contribute, and stop whining. If you dont contribute, 
frankly you dont really exist to me. On the other hand if you are actively 
contributing while your architecture only exists on paper, it already starts 
mattering to me.

I'm really that simple.

Thanks,

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/20] x86: early_res and irq_desc, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 01/20] x86: add find_e820_area_node, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 02/20] x86: add get_centaur_ram_top, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 03/20] x86: make e820 to be static, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 05/20] x86: make e820 to be initdata, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 08/20] x86: fix out of order of gsi - full, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 10/20] x86: kill smpboot_hooks.h, Yinghai Lu, (Sun Mar 21, 12:13 am)
[PATCH 18/20] x86: remove arch_probe_nr_irqs, Yinghai Lu, (Sun Mar 21, 12:13 am)
Re: [PATCH 00/20] x86: early_res and irq_desc, Benjamin Herrenschmidt, (Sun Mar 21, 7:35 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Sun Mar 21, 7:37 pm)
Questions about SMP bootup control, Zhu, Yijun (NSN - CN ..., (Sun Mar 21, 7:46 pm)
Re: [PATCH 00/20] x86: early_res and irq_desc, Yinghai Lu, (Sun Mar 21, 8:26 pm)
Re: Questions about SMP bootup control, Andi Kleen, (Sun Mar 21, 8:29 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Sun Mar 21, 10:12 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Eric W. Biederman, (Mon Mar 22, 12:05 am)
RE: Questions about SMP bootup control, Zhu, Yijun (NSN - CN ..., (Mon Mar 22, 12:45 am)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 1:47 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:01 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:04 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:07 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:08 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:52 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Mon Mar 22, 2:54 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Geert Uytterhoeven, (Tue Mar 23, 1:53 am)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Ingo Molnar, (Tue Mar 23, 4:16 am)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Tue Mar 23, 9:24 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Tue Mar 23, 9:29 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Tue Mar 23, 9:44 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Tue Mar 23, 9:50 pm)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Wed Mar 24, 12:43 am)
Re: [PATCH 06/20] early_res: seperate common memmap func f ..., Benjamin Herrenschmidt, (Wed Mar 24, 2:32 am)