Re: [PATCH] Netfilter: Fix integer overflow in net/ipv6/netfilter/ip6_tables.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: wzt wzt
Date: Monday, March 22, 2010 - 6:34 pm

> I can see that the size might cause an overflow in the addition with
That's the integer overflow i pointed.
get.size is copy from the user space,  it can be set as 0x7fffffff,
addition with sizeof(struct ipt_get_entries) can be overflow.

        if (*len != sizeof(struct ipt_get_entries) + get.size) {
                duprintf("get_entries: %u != %zu\n",
                         *len, sizeof(get) + get.size);
                return -EINVAL;
        }

so, check get.size max value before addition with sizeof(struct
ipt_get_entries) to prevent the integer overflow.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Netfilter: Fix integer overflow in net/ipv6/ne ..., wzt wzt, (Mon Mar 22, 6:34 pm)