Re: [RFC] Unify KVM kernel-space and user-space code into a single project

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Monday, March 22, 2010 - 1:06 pm

* Avi Kivity <avi@redhat.com> wrote:


It's hard for me to argue against a hypothetical implementation, but all 
user-space driven solutions for resource enumeration i've seen so far had 
weaknesses that kernel-based solutions dont have.


I think you didnt understand my point. I am talking about 'perf kvm top' 
hanging if Qemu hangs.

With a proper in-kernel enumeration the kernel would always guarantee the 
functionality, even if the vcpu does not make progress (i.e. it's "hung").

With this implemented in Qemu we lose that kind of robustness guarantee.

And especially during development (when developers use instrumentation the 
most) is it important to have robust instrumentation that does not hang along 
with the Qemu process.


How on earth can you justify a bug ("perf kvm top" hanging) with that there 
are other bugs as well?

Basically you are arguing the equivalent that a gdb session would be fine to 
become unresponsive if the debugged task hangs. Fortunately ptrace is 
kernel-based and it never 'hangs' if the user-space process hangs somewhere.

This is an essential property of good instrumentation.

So the enumeration method you suggested is a poor, sub-part solution, simple 
as that.


We can still profile any of those tools without the profiler breaking if the 
debugged tool breaks ...


(Then you'll be enjoyed to hear that perf has enabled exactly that, and that we 
are working towards that precise usecase.)

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 5:33 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Thu Mar 18, 6:03 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 6:24 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Thu Mar 18, 6:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 7:39 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:10 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frederic Weisbecker, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 12:50 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Fri Mar 19, 2:52 am)
Re: [LKML] Re: [RFC] Unify KVM kernel-space and user-space ..., Konrad Rzeszutek Wilk, (Fri Mar 19, 6:56 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Fri Mar 19, 7:53 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Sat Mar 20, 7:59 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Sun Mar 21, 1:08 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:37 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:54 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 6:05 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 6:23 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 7:01 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Mon Mar 22, 9:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Mon Mar 22, 10:17 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:28 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:30 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:35 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:41 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:15 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:18 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Mon Mar 22, 12:28 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:29 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 12:31 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:33 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Ingo Molnar, (Mon Mar 22, 1:06 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 1:58 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Tue Mar 23, 2:46 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Bernd Petrovitsch, (Tue Mar 23, 3:48 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 6:15 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:10 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:29 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Javier Guerra Giraldez, (Tue Mar 23, 12:05 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Wed Mar 24, 8:26 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 10:47 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 11:27 am)