Re: [PATCH 04/10] x86: kill smpboot_hooks.h

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Gleixner
Date: Monday, March 22, 2010 - 6:34 am

On Sun, 21 Mar 2010, Yinghai Lu wrote:


This is not the way how we do that. We move code in one patch and then
do modification in the follow up patch. Doing both makes it harder
than necessary to follow the code change.

As a side note, that changelog for the removal of
smpboot_clear_io_apic is not telling anything why that change is
functional equivivalent to the original code. And I doubt that it's
correct.

Thanks,

	tglx
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 04/10] x86: kill smpboot_hooks.h, Yinghai Lu, (Sun Mar 21, 6:36 pm)
Re: [PATCH 04/10] x86: kill smpboot_hooks.h, Thomas Gleixner, (Mon Mar 22, 6:34 am)