Re: CrystalHD driver safe on big endian systems?

Previous thread: [Bug #15502] render error detected, EIR: 0x00000010 by Rafael J. Wysocki on Sunday, March 21, 2010 - 1:30 pm. (1 message)

Next thread: [Bug #15474] r8169 fails to bring up ethernet by Rafael J. Wysocki on Sunday, March 21, 2010 - 1:30 pm. (1 message)
From: Leon Woestenberg
Date: Sunday, March 21, 2010 - 2:03 pm

Hello all,

has the CrystalHD driver/library been tested on big endian systems?

The (staging GIT tree) driver sources seem to use bitfields in C, is
this safe under different endianess?

I'm currently testing two BCM70012 modules on a big-endian PowerPC
system and it fails changing the clock PLL to 175 MHz. This could be a
pair of defective modules, or the wrong bits being modified.
Unfortunately, I do not have a little endian system with mini-PCIe
available to do a A-B check.

Regards,
-- 
Leon
--

From: Scott D. Davilla
Date: Sunday, March 21, 2010 - 8:53 pm

Not sure if anyone has done work testing under big endian platforms. 
 From what I've seen in code, it looks definite little endian based 
and would need a look over regarding byte swap.

Scott
--

From: Leon Woestenberg
Date: Monday, March 22, 2010 - 4:32 am

Hello Scott and others,

What parts of the code assumes little endian from what you've seen?

Now, byte swap endianess is one thing, C bitfields in combination with
it, another. I have given it a first shot here (mailer unsuitable for
sending patches), still failed on PowerPC:
http://www.sidebranch.com/crystalhd/

May I suggest we instrument all register access functions with a
printk() of the register being written? Then I can compare little
endian access patterns with big endian, to be sure we get the
bitfields, code assumptions and byte swap correctly.

Regards,
-- 
Leon
--

Previous thread: [Bug #15502] render error detected, EIR: 0x00000010 by Rafael J. Wysocki on Sunday, March 21, 2010 - 1:30 pm. (1 message)

Next thread: [Bug #15474] r8169 fails to bring up ethernet by Rafael J. Wysocki on Sunday, March 21, 2010 - 1:30 pm. (1 message)