Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Monday, March 22, 2010 - 3:59 am

* oerg Roedel <joro@8bytes.org> wrote:


The very same is true of profiling in the host space as well (KVM is nothing 
special here, other than its unreasonable insistence on not enumerating 
readily available information in a more usable way).

So are you suggesting a solution to a perf problem we already solved 
differently? (and which i argue we solved in a better way)

We have solved that in the host space already (and quite elaborately so), and 
not via your suggestion of moving symbol resolution to a different stage, but 
by properly generating the right events to allow the post-processing stage to 
see processes that have already exited, to robustly handle files that have 
been rebuilt, etc.

From an instrumentation POV it is fundamentally better to acquire the right 
data and delay any complexities to the analysis stage (the perf model) than to 
complicate sampling (the oprofile dcookies model).

Your proposal of 'doing the symbol resolution in the guest context' is in 
essence re-arguing that very similar point that oprofile lost. Did you really 
intend to re-argue that point as well? If yes then please propose an 
alternative implementation for everything that perf does wrt. symbol lookups.

What we propose for 'perf kvm' right now is simply a straight-forward 
extension of the existing (and well working) symbol handling code to 
virtualization.


Best would be if you demonstrated any problems of the perf symbol lookup code 
you are aware of on the host side, as it has that exact design you are 
criticising here. We are eager to fix any bugs in it.

If you claim that it's buggy then that should very much be demonstratable - no 
need to go into theoretical arguments about it.

( You should be aware of the fact that perf currently works with 'processes
  exiting prematurely' and similar scenarios just fine, so if you want to
  demonstrate that it's broken you will probably need a different example. )


That is kind of half of my suggestion - the built-in enumeration guests and a 
guaranteed channel to them accessible to tools. (KVM already has its own 
special channel so it's not like channels of communication are useless.)

The other half of my suggestion is that if we bring this thought to its 
logical conclusion then we might as well walk the whole mile and not use 
quirky, binary API single-channel pipes. I.e. we could use this convenient, 
human-readable, structured, hierarchical abstraction to expose information in 
a finegrained, scalable way, which has a world-class implementation in Linux: 
the 'VFS namespace'.

Thanks,

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 5:33 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Thu Mar 18, 6:03 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 6:24 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Thu Mar 18, 6:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 7:39 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:10 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frederic Weisbecker, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 12:50 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Fri Mar 19, 2:52 am)
Re: [LKML] Re: [RFC] Unify KVM kernel-space and user-space ..., Konrad Rzeszutek Wilk, (Fri Mar 19, 6:56 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Fri Mar 19, 7:53 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Sat Mar 20, 7:59 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Sun Mar 21, 1:08 pm)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Ingo Molnar, (Mon Mar 22, 3:59 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:37 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:54 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 6:05 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 6:23 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 7:01 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Mon Mar 22, 9:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Mon Mar 22, 10:17 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:28 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:30 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:35 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:41 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:15 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:18 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Mon Mar 22, 12:28 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:29 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 12:31 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:33 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 1:58 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Tue Mar 23, 2:46 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Bernd Petrovitsch, (Tue Mar 23, 3:48 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 6:15 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:10 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:29 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Javier Guerra Giraldez, (Tue Mar 23, 12:05 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Wed Mar 24, 8:26 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 10:47 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 11:27 am)