Re: [PATCH] x86: remove early_res debug output (was Re: Confusing bootmem messages on bootup)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jiri Kosina
Date: Monday, March 22, 2010 - 1:32 am

On Mon, 22 Mar 2010, Ingo Molnar wrote:


From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] x86: remove early_res debug output

Commit 08677214e318297 ("x86: Make 64 bit use early_res instead of bootmem 
before slab") introduced early_res replacement for bootmem, but left code 
in __free_pages_memory() which dumps all the ranges that are beeing freed, 
without any additional information, causing some noise in dmesg during 
bootup.

Just remove printing of the ranges, that doesn't provide anything useful 
anyway.

While at it, remove other commented-out KERN_DEBUG messages in the 
NO_BOOTMEM code as well.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

--- 
 mm/bootmem.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/mm/bootmem.c b/mm/bootmem.c
index d7c791e..9b13446 100644
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -180,19 +180,12 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end)
 	end_aligned = end & ~(BITS_PER_LONG - 1);
 
 	if (end_aligned <= start_aligned) {
-#if 1
-		printk(KERN_DEBUG " %lx - %lx\n", start, end);
-#endif
 		for (i = start; i < end; i++)
 			__free_pages_bootmem(pfn_to_page(i), 0);
 
 		return;
 	}
 
-#if 1
-	printk(KERN_DEBUG " %lx %lx - %lx %lx\n",
-		 start, start_aligned, end_aligned, end);
-#endif
 	for (i = start; i < start_aligned; i++)
 		__free_pages_bootmem(pfn_to_page(i), 0);
 
@@ -428,9 +421,6 @@ void __init free_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
 {
 #ifdef CONFIG_NO_BOOTMEM
 	free_early(physaddr, physaddr + size);
-#if 0
-	printk(KERN_DEBUG "free %lx %lx\n", physaddr, size);
-#endif
 #else
 	unsigned long start, end;
 
@@ -456,9 +446,6 @@ void __init free_bootmem(unsigned long addr, unsigned long size)
 {
 #ifdef CONFIG_NO_BOOTMEM
 	free_early(addr, addr + size);
-#if 0
-	printk(KERN_DEBUG "free %lx %lx\n", addr, size);
-#endif
 #else
 	unsigned long start, end;
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Confusing bootmem messages on bootup, Jiri Kosina, (Fri Mar 19, 7:30 am)
Re: [PATCH] x86: remove early_res debug output (was Re: Co ..., Jiri Kosina, (Mon Mar 22, 1:32 am)
[tip:core/urgent] x86: Remove excessive early_res debug output, tip-bot for Jiri Kosina, (Wed Mar 24, 4:21 am)
[tip:core/urgent] x86: Remove excessive early_res debug output, tip-bot for Jiri Kosina, (Wed Mar 24, 11:54 am)