Re: [patch] slab: add memory hotplug support

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Rientjes
Date: Tuesday, March 2, 2010 - 2:17 pm

On Tue, 2 Mar 2010, Andi Kleen wrote:


If you still believe these are "fixes," then perhaps you don't fully 
understand the issue: slab completely lacked memory hotplug support when a 
node is either being onlined or offlined that do not have hotadded or 
hotremoved cpus.  It's as simple as that.

To be fair, my patch may appear more complex because it implements full 
memory hotplug support so that the nodelists are properly drained and 
freed when the same memory regions you onlined for memory hot-add are now 
offlined.  Notice, also, how it touches no other slab code as implementing 
new support for something shouldn't.  There is no need for additional 
hacks to be added in other slab code if you properly allocate and 
initialize the nodelists for the memory being added before it is available 
for use by the kernel.

If you'd test my patch out on your setup, that would be very helpful.  I 
can address any additional issues that you may undercover if you post the 
oops while doing either memory online or offline.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Fri Feb 19, 11:22 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Fri Feb 19, 11:22 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Wed Feb 24, 8:49 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Thu Feb 25, 11:30 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Thu Feb 25, 11:34 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Thu Feb 25, 12:19 pm)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Thu Feb 25, 3:31 pm)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, KAMEZAWA Hiroyuki, (Thu Feb 25, 6:09 pm)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Fri Feb 26, 8:04 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Fri Feb 26, 8:05 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, Christoph Lameter, (Fri Feb 26, 10:24 am)
Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap, KAMEZAWA Hiroyuki, (Sun Feb 28, 6:59 pm)
[patch] slab: add memory hotplug support, David Rientjes, (Mon Mar 1, 3:24 am)
Re: [patch] slab: add memory hotplug support, Pekka Enberg, (Mon Mar 1, 10:53 pm)
Re: [patch] slab: add memory hotplug support, Andi Kleen, (Tue Mar 2, 5:53 am)
Re: [patch] slab: add memory hotplug support, Pekka Enberg, (Tue Mar 2, 8:04 am)
Re: [patch] slab: add memory hotplug support, Christoph Lameter, (Tue Mar 2, 1:20 pm)
Re: [patch] slab: add memory hotplug support, David Rientjes, (Tue Mar 2, 2:03 pm)
Re: [patch] slab: add memory hotplug support, David Rientjes, (Tue Mar 2, 2:17 pm)
Re: [patch] slab: add memory hotplug support, KAMEZAWA Hiroyuki, (Tue Mar 2, 6:28 pm)
Re: [patch] slab: add memory hotplug support, David Rientjes, (Tue Mar 2, 7:39 pm)
Re: [patch] slab: add memory hotplug support, KAMEZAWA Hiroyuki, (Tue Mar 2, 7:51 pm)
Re: [patch] slab: add memory hotplug support, Andi Kleen, (Wed Mar 3, 7:34 am)
Re: [patch] slab: add memory hotplug support, Christoph Lameter, (Wed Mar 3, 8:46 am)
Re: [patch] slab: add memory hotplug support, Nick Piggin, (Thu Mar 4, 11:20 pm)
Re: [patch] slab: add memory hotplug support, Anca Emanuel, (Fri Mar 5, 5:47 am)
Re: [patch] slab: add memory hotplug support, Anca Emanuel, (Fri Mar 5, 6:58 am)
Re: [patch] slab: add memory hotplug support, Christoph Lameter, (Fri Mar 5, 7:11 am)
Re: [patch] slab: add memory hotplug support, Andi Kleen, (Sun Mar 7, 7:58 pm)
Re: [patch] slab: add memory hotplug support, Andi Kleen, (Sun Mar 7, 8:06 pm)
Re: [patch] slab: add memory hotplug support, David Rientjes, (Mon Mar 8, 4:19 pm)
Re: [patch] slab: add memory hotplug support, Nick Piggin, (Tue Mar 9, 6:46 am)
Re: [patch] slab: add memory hotplug support, Pekka Enberg, (Mon Mar 22, 10:28 am)
Re: [patch] slab: add memory hotplug support, Nick Piggin, (Mon Mar 22, 2:12 pm)
Re: [patch] slab: add memory hotplug support, David Rientjes, (Sat Mar 27, 7:13 pm)
[patch v2] slab: add memory hotplug support, David Rientjes, (Sat Mar 27, 7:40 pm)
Re: [patch v2] slab: add memory hotplug support, Pekka Enberg, (Tue Mar 30, 2:01 am)
Re: [patch v2] slab: add memory hotplug support, Christoph Lameter, (Tue Mar 30, 9:43 am)
Re: [patch v2] slab: add memory hotplug support, David Rientjes, (Sun Apr 4, 1:45 pm)
Re: [patch v2] slab: add memory hotplug support, Pekka Enberg, (Wed Apr 7, 9:29 am)