[PATCH] x86: do not free zero sized per cpu areas

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Friday, March 19, 2010 - 12:24 pm

From: Ian Campbell <ian.campbell@citrix.com>

This avoids an infinite loop in free_early_partial().

Add a warning to free_early_partial to catch future problems.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/setup_percpu.c |    3 ++-
 kernel/early_res.c             |    5 +++++
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c
index ef6370b..89a3205 100644
--- a/arch/x86/kernel/setup_percpu.c
+++ b/arch/x86/kernel/setup_percpu.c
@@ -140,7 +140,8 @@ static void __init pcpu_fc_free(void *ptr, size_t size)
 #ifdef CONFIG_NO_BOOTMEM
 	u64 start = __pa(ptr);
 	u64 end = start + size;
-	free_early_partial(start, end);
+	if (start < end)
+		free_early_partial(start, end);
 #else
 	free_bootmem(__pa(ptr), size);
 #endif
diff --git a/kernel/early_res.c b/kernel/early_res.c
index 3cb2c66..f3a861b 100644
--- a/kernel/early_res.c
+++ b/kernel/early_res.c
@@ -333,6 +333,11 @@ void __init free_early_partial(u64 start, u64 end)
 	struct early_res *r;
 	int i;
 
+	if (WARN_ONCE(start >= end,
+		      "free_early_partial got wrong start/end %#llx/%#llx\n",
+		      start, end))
+		return;
+
 try_next:
 	i = find_overlapped_early(start, end);
 	if (i >= max_early_res)
-- 
1.5.6.5
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: do not free zero sized per cpu areas, Ian Campbell, (Fri Mar 5, 12:49 pm)
Re: Infinite loop on boot in free_early_partial due to sta ..., Konrad Rzeszutek Wilk, (Fri Mar 19, 11:28 am)
[PATCH] x86: do not free zero sized per cpu areas, Yinghai Lu, (Fri Mar 19, 12:24 pm)
Re: [LKML] Re: Infinite loop on boot in free_early_partial ..., Konrad Rzeszutek Wilk, (Fri Mar 19, 1:04 pm)
Re: [PATCH] x86: do not free zero sized per cpu areas, H. Peter Anvin, (Fri Mar 19, 2:42 pm)
Re: [PATCH -v3] x86: do not free zero sized per cpu areas, H. Peter Anvin, (Fri Mar 19, 3:21 pm)
Re: [PATCH -v3] x86: do not free zero sized per cpu areas, H. Peter Anvin, (Fri Mar 19, 4:29 pm)
Re: [PATCH -v3] x86: do not free zero sized per cpu areas, H. Peter Anvin, (Fri Mar 19, 4:43 pm)
Re: [PATCH -v4] x86: do not free zero sized per cpu areas, Linus Torvalds, (Fri Mar 19, 6:00 pm)
Re: [PATCH -v5] x86: do not free zero sized per cpu areas, Linus Torvalds, (Fri Mar 19, 7:41 pm)
[PATCH -v6] x86: do not free zero sized per cpu areas, Yinghai Lu, (Fri Mar 19, 11:38 pm)
Re: [PATCH -v6] x86: do not free zero sized per cpu areas, Ian Campbell, (Sat Mar 20, 12:12 am)
Re: [LKML] [PATCH -v6] x86: do not free zero sized per cpu ..., Konrad Rzeszutek Wilk, (Mon Mar 22, 10:30 am)