Re: [RFC] Unify KVM kernel-space and user-space code into a single project

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Friday, March 19, 2010 - 1:53 am

* Avi Kivity <avi@redhat.com> wrote:


Erm, my usability points are _doubly_ true when there are multiple guests ...

The inconvenience of having to type:

  perf kvm --host --guest --guestkallsyms=/home/ymzhang/guest/kallsyms \
  --guestmodules=/home/ymzhang/guest/modules top

is very obvious even with a single guest. Now multiply that by more guests ...

The crux is: we are working on improving KVM instrumentation. There are 
working patches posted to this thread and we would like to have/implement an 
automatism to allow the discovery of all this information. The information 
should be available to the developer who wants it, and easily/transparently so 
- in true Linux fashion.


You havent articulated an actionable reason and you have suggested no solution 
either, you just passive-agressive backed the claim that giving developers 
access to the symbol space is some sort of vague 'security threat'.

If that is not so i'd be glad to be proven wrong.


That is the crux of the matter. My experience in these threads was that no-one 
really seems to feel in charge of the whole thing. Should we really wonder why 
KVM usability sucks?


This is one of the weirdest arguments i've seen in this thread. Almost all the 
time do we make contributions conditional on the general shape of the project. 
Developers dont get to do just the fun stuff.

This is a basic quid pro quo: new features introduce risks and create 
additional workload not just to the originating developer but on the rest of 
the community as well. You should check how Linus has pulled new features in 
the past 15 years: he very much requires the existing code to first be 
top-notch before he accepts new features for a given area of functionality.

Doing that and insisting on developers to see those imbalances as well is 
absolutely essential to code quality: otherwise everyone would be running 
around implementing just the features they are interested in, without regard 
for the general health of the project.

Of course, if you keep the project in two halves (KVM and Qemu), and pretend 
that they are separate and have little relation, imbalances of quality can 
mount up and you can throw your hands up and say that it's "too bad, I'm not 
maintaining that". It is your basic duty as a Linux maintainer to keep 
balances of quality. I do it all day, other maintainers do it all day.


No, my suggestion to you (it's up to you whether you give my opinion any 
weight) is to accept your mistakes and improve, and to not stand in the way of 
people who'd like to improve the situation. You are happy with the server 
features and you also made it clear that you dont feel responsible for the 
rest of the package - which is a big mistake IMO.

Also, you have demonstrated it in this thread that you have near zero 
technical clue about basic desktop and development usability matters - for 
example your stance on symbol space access and your stance on how to enumerate 
guests symbolically are outright bizarre.

Thanks,

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 5:33 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Thu Mar 18, 6:03 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 6:24 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Thu Mar 18, 6:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 7:39 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:10 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frederic Weisbecker, (Thu Mar 18, 11:20 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Thu Mar 18, 12:50 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Ingo Molnar, (Fri Mar 19, 1:53 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Fri Mar 19, 2:52 am)
Re: [LKML] Re: [RFC] Unify KVM kernel-space and user-space ..., Konrad Rzeszutek Wilk, (Fri Mar 19, 6:56 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Fri Mar 19, 7:53 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Sat Mar 20, 7:59 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Sun Mar 21, 1:08 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:37 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 5:54 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 6:05 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 6:23 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Richard W.M. Jones, (Mon Mar 22, 7:01 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Mon Mar 22, 9:44 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Frank Ch. Eigler, (Mon Mar 22, 10:17 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:28 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:30 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:35 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 11:41 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:15 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:18 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Andrea Arcangeli, (Mon Mar 22, 12:28 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:29 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 12:31 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Anthony Liguori, (Mon Mar 22, 12:33 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Mon Mar 22, 1:58 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Olivier Galibert, (Tue Mar 23, 2:46 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Bernd Petrovitsch, (Tue Mar 23, 3:48 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 6:15 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:10 am)
Re: [PATCH] Enhance perf to collect KVM guest os statistic ..., Arnaldo Carvalho de Melo, (Tue Mar 23, 7:29 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Javier Guerra Giraldez, (Tue Mar 23, 12:05 pm)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Daniel P. Berrange, (Wed Mar 24, 8:26 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 10:47 am)
Re: [RFC] Unify KVM kernel-space and user-space code into ..., Arnaldo Carvalho de Melo, (Wed Mar 24, 11:27 am)