Home » Mailing list archives » linux-kernel » 2010 » March » 19

Re: [stable] [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families

Previous thread: [patch 072/123] ath9k: fix rate control fallback rate selection by Greg KH on Friday, March 12, 2010 - 5:12 pm. (1 message)

Next thread: [patch 069/123] netdevice.h: check for CONFIG_WLAN instead of CONFIG_WLAN_80211 by Greg KH on Friday, March 12, 2010 - 5:12 pm. (1 message)
[view original message]
From: Greg KH
Subject: [patch 070/123] ath9k: re-enable ps by default for new single chip families
Date: Friday, March 12, 2010 - 5:12 pm

2.6.33-stable review patch.  If anyone has any objections, please let me know.

-----------------

From: Luis R. Rodriguez <lrodriguez@atheros.com>

commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream.

The newer single chip hardware family of chipsets have not been
experiencing issues with power saving set by default with recent
fixes merged (even into stable). The remaining issues are only
reported with AR5416 and since enabling PS by default can increase
power savings considerably best to take advantage of that feature
as this has been tested properly.

For more details on this issue see the bug report:

http://bugzilla.kernel.org/show_bug.cgi?id=14267

We leave AR5416 with PS disabled by default, that seems to require
some more work.

Cc: Peter Stuge <peter@stuge.se>
Cc: Justin P. Mattock  <justinmattock@gmail.com>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/net/wireless/ath/ath9k/main.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1849,6 +1849,8 @@ bad_free_hw:
 
 void ath_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 {
+	struct ath_hw *ah = sc->sc_ah;
+
 	hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
 		IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
 		IEEE80211_HW_SIGNAL_DBM |
@@ -1866,7 +1868,8 @@ void ath_set_hw_capab(struct ath_softc *
 		BIT(NL80211_IFTYPE_ADHOC) |
 		BIT(NL80211_IFTYPE_MESH_POINT);
 
-	hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+	if (AR_SREV_5416(ah))
+		hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
 
 	hw->queues = 4;
 	hw->max_rates = 4;


--


[ message continues ]
[view original message]
From: Luis R. Rodriguez
Subject: Re: [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families
Date: Monday, March 15, 2010 - 6:04 pm

This was intended for 2.6.32 as well. Thanks

--


[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [stable] [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families
Date: Thursday, March 18, 2010 - 5:04 pm

Great, but it didn't apply there, so I didn't try to force it :)

Care to provide a backport?

thanks,

greg k-h
--


[ message continues ]
[view original message]
From: Luis R. Rodriguez
Subject: Re: [Stable-review] [stable] [patch 070/123] ath9k: re-enable ps by default for new single chip families
Date: Tuesday, March 23, 2010 - 12:26 pm

Senthil, if you get a chance, can you send this backport? Sorry I
haven't had a chance yet.

  Luis
--


[ message continues ]
[view original message]
From: Luis R. Rodriguez
Subject: Re: [stable] [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families
Date: Friday, April 2, 2010 - 10:37 am

Sorry, been, busy, I've put together a page to keep track of these sort of things:

http://wireless.kernel.org/en/developers/stable-pending

  Luis
--


[ message continues ]
Previous thread: [patch 072/123] ath9k: fix rate control fallback rate selection by Greg KH on Friday, March 12, 2010 - 5:12 pm. (1 message)

Next thread: [patch 069/123] netdevice.h: check for CONFIG_WLAN instead of CONFIG_WLAN_80211 by Greg KH on Friday, March 12, 2010 - 5:12 pm. (1 message)