login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
March
»
15
Re: [PATCH 1/2] kmod: add init function to usermodehelper
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Oleg Nesterov
Subject:
Re: [PATCH 1/2] kmod: add init function to usermodehelper
Date: Monday, March 15, 2010 - 10:34 am
On 03/15, Neil Horman wrote:
quoted text
> > --- a/kernel/kmod.c > +++ b/kernel/kmod.c > @@ -116,27 +116,16 @@ int __request_module(bool wait, const char *fmt, ...) > > trace_module_request(module_name, wait, _RET_IP_); > > - ret = call_usermodehelper(modprobe_path, argv, envp, > - wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC); > + ret = call_usermodehelper_fns(modprobe_path, argv, envp, > + wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC, > + NULL, NULL, NULL);
This change looks unnecessary, but doesn't hurt. Reviewed-by: Oleg Nesterov <oleg@redhat.com> --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/2] exec: refactor how call_usermodehelper works, ...
, Neil Horman
, (Mon Mar 15, 5:29 am)
Re: [PATCH 1/2] kmod: add init function to usermodehelper
, Neil Horman
, (Mon Mar 15, 5:33 am)
Re: [PATCH 2/2] exec: replace call_usermodehelper_pipe wit ...
, Neil Horman
, (Mon Mar 15, 5:36 am)
Re: [PATCH 1/2] kmod: add init function to usermodehelper
, Oleg Nesterov
, (Mon Mar 15, 10:34 am)
Re: [PATCH 2/2] exec: replace call_usermodehelper_pipe wit ...
, Oleg Nesterov
, (Mon Mar 15, 10:39 am)
Re: [PATCH 1/2] kmod: add init function to usermodehelper
, Neil Horman
, (Mon Mar 15, 10:56 am)
[PATCH 0/6] umh: keys, signals, misc
, Oleg Nesterov
, (Mon Mar 15, 12:46 pm)
[PATCH 1/6] umh: creds: convert call_usermodehelper_keys() ...
, Oleg Nesterov
, (Mon Mar 15, 12:46 pm)
[PATCH 2/6] umh: creds: kill subprocess_info->cred logic
, Oleg Nesterov
, (Mon Mar 15, 12:47 pm)
[PATCH 3/6] call_usermodehelper: no need to unblock signals
, Oleg Nesterov
, (Mon Mar 15, 12:47 pm)
[PATCH 4/6] wait_for_helper: SIGCHLD from user-space can l ...
, Oleg Nesterov
, (Mon Mar 15, 12:48 pm)
[PATCH 5/6] call_usermodehelper: simplify/fix UMH_NO_WAIT case
, Oleg Nesterov
, (Mon Mar 15, 12:48 pm)
[PATCH 6/6] call_usermodehelper: UMH_WAIT_EXEC ignores ker ...
, Oleg Nesterov
, (Mon Mar 15, 12:49 pm)
[PATCH 0/4] do_coredump: cleanups
, Oleg Nesterov
, (Tue Mar 16, 12:37 pm)
[PATCH 1/4] coredump: factor out the not-ispipe file checks
, Oleg Nesterov
, (Tue Mar 16, 12:38 pm)
[PATCH 2/4] coredump: cleanup "ispipe" code
, Oleg Nesterov
, (Tue Mar 16, 12:38 pm)
[PATCH 3/4] coredump: factor out put_cred() calls
, Oleg Nesterov
, (Tue Mar 16, 12:39 pm)
[PATCH 4/4] coredump: shift down_write(mmap_sem) into core ...
, Oleg Nesterov
, (Tue Mar 16, 12:39 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Christoph Lameter
[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov
Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz
Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes
Re: PCI probing changes
git
:
Jakub Narebski
Re: GSoC 2008 - Mentors Wanted!
Jan Harkes
Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins
git-fetch fails with error code 128
Marcus Griep
Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano
Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head
:
Linux Kernel Mailing List
ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List
sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List
No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List
x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List
Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev
:
Eric Dumazet
[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy
[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V
RE: __bad_udelay in network driver breaks build
Patrick McHardy
Re: no reassembly for outgoing packets on RAW socket
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
ropers
Re: Real men don't attack straw men
elitdostlar
Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree
Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén
Re: sshd.config and AllowUsers
Henning Brauer
Re: Sun Blade 1000?
Colocation donated by:
Syndicate