[PATCH 05/10] ARM: ftrace: add ENDPROC annotations

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rabin Vincent
Date: Friday, March 12, 2010 - 11:49 pm

When building as Thumb-2, the ".type foo, %function" annotation in
ENDPROC seems to be required in order for the assembly routines to be
recognized as Thumb-2 code.  If the ENDPROC annotations are not present,
calls to these routines are generated as BLX instead of BL.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Rabin Vincent <rabin@rab.in>
---
 arch/arm/kernel/entry-common.S |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index 6805a72..c3bdb05 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -146,6 +146,7 @@ mcount_call:
 	bl	ftrace_stub
 	ldr	lr, [fp, #-4]			@ restore lr
 	ldmia	sp!, {r0-r3, pc}
+ENDPROC(mcount)
 
 ENTRY(ftrace_caller)
 	stmdb	sp!, {r0-r3, lr}
@@ -158,6 +159,7 @@ ftrace_call:
 	bl	ftrace_stub
 	ldr	lr, [fp, #-4]			@ restore lr
 	ldmia	sp!, {r0-r3, pc}
+ENDPROC(ftrace_caller)
 
 #else
 
@@ -179,6 +181,7 @@ gnu_trace:
 	mov	pc, r2
 	ldmia	sp!, {r0-r3, ip, lr}
 	mov	pc, ip
+ENDPROC(__gnu_mcount_nc)
 
 #ifdef CONFIG_OLD_MCOUNT
 /*
@@ -204,13 +207,15 @@ trace:
 	mov	pc, r2
 	ldr	lr, [fp, #-4]			@ restore lr
 	ldmia	sp!, {r0-r3, pc}
+ENDPROC(mcount)
 #endif
 
 #endif /* CONFIG_DYNAMIC_FTRACE */
 
 	.globl ftrace_stub
-ftrace_stub:
+ENTRY(ftrace_stub)
 	mov	pc, lr
+ENDPROC(ftrace_stub)
 
 #endif /* CONFIG_FUNCTION_TRACER */
 
-- 
1.7.0

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/10] ARM: ftrace: document mcount formats, Rabin Vincent, (Fri Mar 12, 11:49 pm)
[PATCH 05/10] ARM: ftrace: add ENDPROC annotations, Rabin Vincent, (Fri Mar 12, 11:49 pm)
[PATCH 06/10] ARM: ftrace: add Thumb-2 support, Rabin Vincent, (Fri Mar 12, 11:49 pm)
[PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace, Rabin Vincent, (Fri Mar 12, 11:49 pm)
[PATCH 10/10] ARM: ftrace: enable dynamic ftrace, Rabin Vincent, (Fri Mar 12, 11:49 pm)
Re: [PATCH 05/10] ARM: ftrace: add ENDPROC annotations, Russell King - ARM Linux, (Sat Mar 13, 1:45 am)
Re: [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace, Steven Rostedt, (Sat Mar 13, 10:42 am)
Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support, Catalin Marinas, (Sun Mar 14, 3:30 pm)
Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support, Rabin Vincent, (Mon Mar 15, 11:32 am)
Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support, Catalin Marinas, (Tue Mar 16, 3:23 am)
Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support, Rabin Vincent, (Wed Mar 31, 11:25 am)
Re: [PATCH 05/10] ARM: ftrace: add ENDPROC annotations, Rabin Vincent, (Wed Apr 21, 12:23 pm)
Re: [PATCH 06/10] ARM: ftrace: add Thumb-2 support, Catalin Marinas, (Fri Apr 23, 8:37 am)
Re: [PATCH 07/10] ftrace: pass KBUILD_CFLAGS to record_mco ..., Frederic Weisbecker, (Fri Aug 6, 8:31 am)
Re: [PATCH 05/10] ARM: ftrace: add ENDPROC annotations, Catalin Marinas, (Tue Aug 10, 10:07 am)
Re: [PATCH 05/10] ARM: ftrace: add ENDPROC annotations, Rabin Vincent, (Tue Aug 10, 12:11 pm)