Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: OGAWA Hirofumi

Subject: Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one

Date: Thursday, March 11, 2010 - 2:03 am

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

quoted text> On Thu, Mar 11, 2010 at 1:18 AM, OGAWA Hirofumi
> <hirofumi@mail.parknet.co.jp> wrote:
>>> +                             *op++ = hex_asc_hi(ec >> 8);
>>> +                             *op++ = hex_asc_lo(ec >> 8);
>>> +                             *op++ = hex_asc_hi(ec);
>>> +                             *op++ = hex_asc_lo(ec);
>> Why doesn't this use pack_hex_byte()?
> No specific reason, it could be so. Would you like me to change this?

Yes, please change it if you have no problem.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., OGAWA Hirofumi, (Wed Mar 10, 4:18 pm)

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., Andy Shevchenko, (Thu Mar 11, 12:14 am)

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., Joe Perches, (Thu Mar 11, 12:21 am)

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., Andy Shevchenko, (Thu Mar 11, 12:59 am)

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., Joe Perches, (Thu Mar 11, 1:10 am)

Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead ..., OGAWA Hirofumi, (Thu Mar 11, 2:03 am)

[PATCHv2] fs: fat: use pack_hex_byte() instead of custom one, Andy Shevchenko, (Thu Mar 11, 8:00 am)

Re: [PATCHv2] fs: fat: use pack_hex_byte() instead of cust ..., OGAWA Hirofumi, (Thu Mar 11, 8:12 am)

Re: [PATCHv2] fs: fat: use pack_hex_byte() instead of cust ..., Andy Shevchenko, (Thu Mar 11, 8:15 am)

Re: [PATCHv3] fs: fat: use pack_hex_byte() instead of cust ..., OGAWA Hirofumi, (Sat Mar 13, 4:09 am)


linux-kernel:
Mel Gorman	Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck	Re: [lm-sensors] Location for thermal drivers
David Woodhouse	Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B	Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra	Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head:
Linux Kernel Mailing List	[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List	USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List	lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List	[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List	[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev:
MERCEDES	Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller	Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller	Re: skb_segment() questions
Shan Wei	[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka	[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git:
Nicolas Sebrecht	git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano	Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff	Re: [PATCH] GIT commit statistics.
Alexandre Julliard	[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett	[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc:
Taisto Qvist XX	Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer	Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier	Re: jetway board sensors (Fintek F71805F)
admin	Drive a 2009 car from R799p/m
Antti Harri	Re: how to create a sha256 hash