Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup lock (Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

On Thu, 11 Mar 2010 13:58:47 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

How about this ? Assume that the race is very rare.

	1. use trylock when updating statistics.
	   If trylock fails, don't account it.

	2. add PCG_FLAG for all status as

+	PCG_ACCT_FILE_MAPPED, /* page is accounted as file rss*/
+	PCG_ACCT_DIRTY, /* page is dirty */
+	PCG_ACCT_WRITEBACK, /* page is being written back to disk */
+	PCG_ACCT_WRITEBACK_TEMP, /* page is used as temporary buffer for FUSE */
+	PCG_ACCT_UNSTABLE_NFS, /* NFS page not yet committed to the server */

	3. At reducing counter, check PCG_xxx flags by
	TESTCLEARPCGFLAG()

This is similar to an _used_ method of LRU accounting. And We can think this
method's error-range never go too bad number. 

I think this kind of fuzzy accounting is enough for writeback status.
Does anyone need strict accounting ?

Thanks,
-Kame

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mmotm 0/4] memcg: per cgroup dirty limit (v5), Andrea Righi, (Sun Mar 7, 1:57 pm)
[PATCH -mmotm 1/4] memcg: dirty memory documentation, Andrea Righi, (Sun Mar 7, 1:57 pm)
[PATCH -mmotm 4/4] memcg: dirty pages instrumentation, Andrea Righi, (Sun Mar 7, 1:57 pm)
Re: [PATCH -mmotm 4/4] memcg: dirty pages instrumentation, KAMEZAWA Hiroyuki, (Sun Mar 7, 7:31 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Mon Mar 8, 7:07 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., Daisuke Nishimura, (Tue Mar 9, 6:43 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., Daisuke Nishimura, (Wed Mar 10, 9:31 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Wed Mar 10, 9:49 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., Daisuke Nishimura, (Wed Mar 10, 9:58 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Wed Mar 10, 10:13 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Wed Mar 10, 11:15 pm)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., Daisuke Nishimura, (Thu Mar 11, 12:50 am)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Thu Mar 11, 1:06 am)
Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup ..., KAMEZAWA Hiroyuki, (Thu Mar 11, 4:46 pm)