Re: [PATCH 1/2 V3] io-controller: Add a new interface "weight_device" for IO-Controller

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chad Talbott
Date: Wednesday, March 10, 2010 - 10:38 am

On Wed, Mar 10, 2010 at 7:30 AM, Vivek Goyal <vgoyal@redhat.com> wrote:

It looks like we have that pairing way back in blk_register_queue()
which takes a gendisk.  Is there any reason we don't hold onto the
gendisk there?  Eyeballing add_disk() and unlink_gendisk() seems to
confirm that gendisk lifetime spans request_queue.

Nauman and I were also wondering why blkio_group and blkio_policy_node
store a dev_t, rather than a direct pointer to gendisk.  dev_t seems
more like a userspace<->kernel interface than an inside-the-kernel
interface.

Chad
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/2 V3] io-controller: Add a new interface "wei ..., Chad Talbott, (Wed Mar 10, 10:38 am)