[PATCH 1/7] mmc: at91_mci: fix pointer errors

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Nicolas Ferre
Date: Friday, February 26, 2010 - 11:39 am

From: Wolfgang Muees <wolfgang.mues@auerswald.de>

Fixes two pointer errors, one which leads to memory overwrites if used with
large chunks of data.

Signed-off-by: Wolfgang Muees <wolfgang.mues@auerswald.de>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
 drivers/mmc/host/at91_mci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
index 63924e0..6835104 100644
--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -227,11 +227,13 @@ static inline void at91_mci_sg_to_dma(struct at91mci_host *host, struct mmc_data
 			for (index = 0; index < (amount / 4); index++)
 				*dmabuf++ = swab32(sgbuffer[index]);
 		} else {
-			memcpy(dmabuf, sgbuffer, amount);
-			dmabuf += amount;
+			char *tmpv = (char *)dmabuf;
+			memcpy(tmpv, sgbuffer, amount);
+			tmpv += amount;
+			dmabuf = (unsigned *)tmpv;
 		}
 
-		kunmap_atomic(sgbuffer, KM_BIO_SRC_IRQ);
+		kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ);
 
 		if (size == 0)
 			break;
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/7] mmc: at91_mci: fix pointer errors, Nicolas Ferre, (Fri Feb 26, 11:39 am)
[PATCH 2/7] mmc: at91_mci: fix timeout errors, Nicolas Ferre, (Fri Feb 26, 11:39 am)
[PATCH 3/7] mmc: at91_mci: use one coherent DMA buffer, Nicolas Ferre, (Fri Feb 26, 11:39 am)
[PATCH 4/7] mmc: at91_mci: use DMA buffer for read, Nicolas Ferre, (Fri Feb 26, 11:39 am)
[PATCH 5/7] mmc: at91_mci: enable large data blocks, Nicolas Ferre, (Fri Feb 26, 11:39 am)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Dan Carpenter, (Fri Feb 26, 1:20 pm)
Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read, Andrew Morton, (Tue Mar 2, 2:34 pm)
Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read, Wolfgang =?iso-8859- ..., (Wed Mar 3, 12:34 am)
[PATCH] mmc: at91_mci: correct kunmap_atomic(), Nicolas Ferre, (Wed Mar 3, 7:17 am)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Chris Ball, (Fri Aug 27, 12:33 pm)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Chris Ball, (Fri Aug 27, 12:34 pm)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Ryan Mallon, (Sun Aug 29, 2:39 pm)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Wolfgang Mües, (Sun Aug 29, 11:51 pm)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Wolfgang Mües, (Sun Aug 29, 11:56 pm)
Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors, Ryan Mallon, (Mon Aug 30, 12:05 am)