On Fri, Feb 26, 2010 at 02:35:24PM +0200, Pekka Enberg wrote:
Let's put it like this: i'm sure there a myriad different
way in all the possible design spaces to change slab to
make memory hotadd work.
Unless someone gives me a strong reason (e.g. code as submitted
doesn't work or is really unclean) I'm not very motivated to try them
all (also given that slab.c is really legacy code that will
hopefully go away at some point).
Also there are still other bugs to fix in memory hotadd and I'm focussing
my efforts on that.
I don't think the patches I submitted are particularly intrusive or
unclean or broken.
As far as I can see Christoph's proposal was just another way
to do this, but it wasn't clear to me it was better enough
in any way to spend significant time on it.
So yes I would prefer if you merged them as submitted just
to fix the bugs. If someone else comes up with a better way
to do this and submits patches they could still change
to that later.
As for the timer race patch: I cannot make a strong
argument right now that it's needed, on the other hand
a bit of defensive programming also doesn't hurt. But
if that one is not in I won't cry.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
