Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom mode

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Rientjes
Date: Wednesday, February 17, 2010 - 2:11 am

On Wed, 17 Feb 2010, KAMEZAWA Hiroyuki wrote:


That's been fixed, right?


We can detect this with is_vm_hugetlb_page() if we pass the vma into 
pagefault_out_of_memory() without adding another VM_FAULT flag.


See below.


That looks appropriate at first glance.


The filemap, shmem, and block_prepare_write() cases will call the oom 
killer but, depending on the gfp mask, they will retry their allocations 
after the oom killer is called so we should never return VM_FAULT_OOM 
because they return -ENOMEM.  They fail from either small objsize slab 
allocations or with orders less than PAGE_ALLOC_COSTLY_ORDER which by 
default continues to retry even if direct reclaim fails.  If we're 
returning with VM_FAULT_OOM from these handlers, it should only be because 
of GFP_NOFS | __GFP_NORETRY or current has been oom killed and still can't 
find memory (so we don't care if the oom killer is called again since it 
won't kill anything else).

So like I said, I don't really see a need where VM_FAULT_NO_RESOURCE would 
be helpful in any case other than hugetlb which we can already detect by 
passing the vma into the pagefault oom handler.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch -mm 0/9 v2] oom killer rewrite, David Rientjes, (Mon Feb 15, 3:19 pm)
[patch -mm 5/9 v2] oom: badness heuristic rewrite, David Rientjes, (Mon Feb 15, 3:20 pm)
[patch -mm 6/9 v2] oom: deprecate oom_adj tunable, David Rientjes, (Mon Feb 15, 3:20 pm)
[patch -mm 7/9 v2] oom: replace sysctls with quick mode, David Rientjes, (Mon Feb 15, 3:20 pm)
Re: [patch -mm 6/9 v2] oom: deprecate oom_adj tunable, David Rientjes, (Mon Feb 15, 3:35 pm)
Re: [patch -mm 8/9 v2] oom: avoid oom killer for lowmem al ..., KAMEZAWA Hiroyuki, (Mon Feb 15, 4:57 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Mon Feb 15, 5:00 pm)
Re: [patch -mm 8/9 v2] oom: avoid oom killer for lowmem al ..., KAMEZAWA Hiroyuki, (Mon Feb 15, 5:21 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Mon Feb 15, 5:23 pm)
[patch] mm: add comment about deprecation of __GFP_NOFAIL, David Rientjes, (Mon Feb 15, 6:13 pm)
Re: [patch] mm: add comment about deprecation of __GFP_NOFAIL, KAMEZAWA Hiroyuki, (Mon Feb 15, 6:26 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 1:10 am)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 4:42 pm)
Re: [patch -mm 8/9 v2] oom: avoid oom killer for lowmem al ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 4:48 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 5:01 pm)
Re: [patch -mm 8/9 v2] oom: avoid oom killer for lowmem al ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 5:03 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 5:41 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 6:03 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 7:13 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 7:23 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 7:34 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Tue Feb 16, 8:21 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., David Rientjes, (Wed Feb 17, 2:11 am)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., Daisuke Nishimura, (Sun Feb 21, 10:31 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Sun Feb 21, 11:15 pm)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., Daisuke Nishimura, (Mon Feb 22, 4:42 am)
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom ..., KAMEZAWA Hiroyuki, (Mon Feb 22, 4:51 pm)