Home » Mailing list archives » linux-kernel » 2010 » February » 16

Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Kosina
Subject: Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps
Date: Tuesday, February 16, 2010 - 5:55 am

On Tue, 16 Feb 2010, Ed Tomlinson wrote:


The routine wasn't probably meant/designed with re-entrancy in mind, but 
looking quickly at all the subsequent callpaths, I don't see why it should 
cause any problem, as skb_queue_purge(), usb_kill_urb() and usb_free_urb() 
should be safe.

Maybe we should even add test_bit() for HID_STARTED and HID_DISCONNECTED 
at the beginning of the low-level drivers' ->stop callbacks, so that we 
don't do all the magic when all the work has been already done.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] HID: make raw output callback more flexible, Jiri Kosina, (Fri Jan 29, 7:20 am)
[PATCH 1/3] HID: make raw reports possible for both featur ..., Jiri Kosina, (Fri Jan 29, 7:20 am)
[PATCH 2/3] HID: Implement Wacom quirk in the kernel, Jiri Kosina, (Fri Jan 29, 7:20 am)
[PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth, Jiri Kosina, (Fri Jan 29, 7:21 am)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Bastien Nocera, (Fri Jan 29, 9:39 am)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Michael Poole, (Fri Jan 29, 5:46 pm)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Bastien Nocera, (Sat Jan 30, 7:11 am)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Marcel Holtmann, (Sat Jan 30, 7:13 am)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Michael Poole, (Sat Jan 30, 8:27 pm)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Michael Poole, (Tue Feb 2, 6:25 pm)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Bastien Nocera, (Wed Feb 3, 2:47 am)
Re: [PATCH 0/3] HID: make raw output callback more flexible, Jiri Kosina, (Wed Feb 3, 5:48 am)
[PATCH 1/3] HID: make raw reports possible for both featur ..., Jiri Kosina, (Wed Feb 3, 5:49 am)
[PATCH 2/3] HID: Implement Wacom quirk in the kernel, Jiri Kosina, (Wed Feb 3, 5:49 am)
[PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth, Jiri Kosina, (Wed Feb 3, 5:50 am)
Re: [PATCH 1/3] HID: make raw reports possible for both fe ..., Marcel Holtmann, (Wed Feb 3, 7:14 am)
Re: [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth, Marcel Holtmann, (Wed Feb 3, 7:17 am)
Re: [PATCH 2/3] HID: Implement Wacom quirk in the kernel, Marcel Holtmann, (Wed Feb 3, 7:19 am)
Re: [PATCH 1/3] HID: make raw reports possible for both fe ..., Jiri Kosina, (Wed Feb 3, 7:37 am)
Re: [PATCH 2/3] HID: Implement Wacom quirk in the kernel, Jiri Kosina, (Wed Feb 3, 7:40 am)
Re: [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth, Jiri Kosina, (Wed Feb 3, 7:42 am)
Re: [PATCH 2/3] HID: Implement Wacom quirk in the kernel, Jiri Kosina, (Wed Feb 3, 7:50 am)
[PATCH] Bluetooth: Keep a copy of each HID device's report ..., Michael Poole, (Thu Feb 4, 5:26 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Marcel Holtmann, (Thu Feb 4, 7:23 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Bastien Nocera, (Fri Feb 5, 5:49 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Marcel Holtmann, (Fri Feb 5, 6:27 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Michael Poole, (Fri Feb 5, 10:23 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Marcel Holtmann, (Fri Feb 5, 10:51 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Ed Tomlinson, (Mon Feb 8, 7:06 pm)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Justin Mattock, (Tue Feb 9, 12:22 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Bastien Nocera, (Tue Feb 9, 3:14 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Ed Tomlinson, (Tue Feb 9, 5:36 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Jiri Kosina, (Tue Feb 9, 5:40 am)
[PATCH 0/2] Provide a driver for the Apple Magic Mouse, Michael Poole, (Tue Feb 9, 6:10 am)
[PATCH 1/2] Provide a driver for the Apple Magic Mouse, Michael Poole, (Tue Feb 9, 6:11 am)
[PATCH 2/2] Add a device driver for the Apple Magic Mouse., Michael Poole, (Tue Feb 9, 6:13 am)
Re: [PATCH] Bluetooth: Keep a copy of each HID device's re ..., Justin P. Mattock, (Tue Feb 9, 8:03 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse, Justin P. Mattock, (Tue Feb 9, 2:37 pm)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Jiri Kosina, (Wed Feb 10, 6:06 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse, Jiri Kosina, (Wed Feb 10, 6:57 am)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Jiri Kosina, (Wed Feb 10, 6:58 am)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Dmitry Torokhov, (Wed Feb 10, 11:20 am)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Michael Poole, (Wed Feb 10, 1:31 pm)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Ed Tomlinson, (Wed Feb 10, 8:05 pm)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse., Michael Poole, (Wed Feb 10, 8:20 pm)
[PATCH] hid-magicmouse: Coding style and probe failure fixes., Michael Poole, (Wed Feb 10, 10:32 pm)
Re: [PATCH] hid-magicmouse: Coding style and probe failure ..., Dmitry Torokhov, (Wed Feb 10, 11:55 pm)
Re: [PATCH] hid-magicmouse: Coding style and probe failure ..., Jiri Kosina, (Thu Feb 11, 3:26 am)
Re: [PATCH 2/2] Add a device driver for the Apple Magic Mo ..., Ed Tomlinson, (Thu Feb 11, 5:51 am)
Re: [PATCH] hid-magicmouse: Coding style and probe failure ..., Michael Poole, (Thu Feb 11, 4:10 pm)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Ed Tomlinson, (Sat Feb 13, 12:29 pm)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Dmitry Torokhov, (Sun Feb 14, 1:03 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Ed Tomlinson, (Sun Feb 14, 7:22 am)
[PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Ed Tomlinson, (Sun Feb 14, 3:24 pm)
Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Michael Poole, (Sun Feb 14, 3:51 pm)
Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Ed Tomlinson, (Sun Feb 14, 4:58 pm)
Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Ed Tomlinson, (Sun Feb 14, 5:18 pm)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Dmitry Torokhov, (Mon Feb 15, 12:11 am)
Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Dmitry Torokhov, (Mon Feb 15, 12:18 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Ed Tomlinson, (Mon Feb 15, 5:42 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Ed Tomlinson, (Mon Feb 15, 5:44 am)
Re: [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse, Ed Tomlinson, (Mon Feb 15, 5:50 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Ed Tomlinson, (Tue Feb 16, 5:34 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Jiri Kosina, (Tue Feb 16, 5:55 am)
Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse ..., Jiri Kosina, (Tue Feb 16, 5:57 am)