[tip:x86/apic-cleanups] x86, ioapic: Avoid writing io_apic id if already correct

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: tip-bot for Yinghai Lu
Date: Thursday, December 9, 2010 - 1:56 pm

Commit-ID:  60d79fd99ff3b9c692b260a4d53a203f537c052a
Gitweb:     http://git.kernel.org/tip/60d79fd99ff3b9c692b260a4d53a203f537c052a
Author:     Yinghai Lu <yinghai@kernel.org>
AuthorDate: Tue, 7 Dec 2010 00:59:49 -0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 9 Dec 2010 21:52:05 +0100

x86, ioapic: Avoid writing io_apic id if already correct

For 32bit mptable path, setup_ids_from_mpc() always writes the io_apic
id register, even there is no change needed.

Skip the write, when readout and mptable match.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
LKML-Reference: <4CFDF785.7010401@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/apic/io_apic.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 4abf08a..8a02150 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2007,9 +2007,12 @@ void __init setup_ioapic_ids_from_mpc_nocheck(void)
 						= mp_ioapics[apic_id].apicid;
 
 		/*
-		 * Read the right value from the MPC table and
-		 * write it into the ID register.
+		 * Update the ID register according to the right value
+		 * from the MPC table if they are different.
 		 */
+		if (mp_ioapics[apic_id].apicid == reg_00.bits.ID)
+			continue;
+
 		apic_printk(APIC_VERBOSE, KERN_INFO
 			"...changing IO-APIC physical APIC ID to %d ...",
 			mp_ioapics[apic_id].apicid);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Add device tree support for x86, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 01/11] x86/kernel: remove conditional early remap i ..., Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 02/11] x86: Add device tree support, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 03/11] x86/dtb: Add a device tree for CE4100, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 04/11] x86/dtb: add irq host abstraction, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 05/11] x86/dtb: add early parsing of APIC and IO APIC, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 06/11] x86/dtb: add support hpet, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 07/11] x86/dtb: add support for PCI devices backed ..., Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 08/11] x86/dtb: Add generic bus probe, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 09/11] x86/ioapic: Add OF bindings for IO-APIC, Sebastian Andrzej Si ..., (Thu Nov 25, 10:39 am)
[PATCH 10/11] x86/io_apic: add simply id set, Sebastian Andrzej Si ..., (Thu Nov 25, 10:40 am)
[PATCH 11/11] x86/ce4100: use OF for ioapic, Sebastian Andrzej Si ..., (Thu Nov 25, 10:40 am)
Re: [PATCH 04/11] x86/dtb: add irq host abstraction , Jon Loeliger, (Thu Nov 25, 12:30 pm)
Re: [PATCH 10/11] x86/io_apic: add simply id set, Yinghai Lu, (Thu Nov 25, 2:04 pm)
Re: [PATCH 02/11] x86: Add device tree support, Sam Ravnborg, (Thu Nov 25, 3:53 pm)
Re: [PATCH 02/11] x86: Add device tree support, Sebastian Andrzej Si ..., (Fri Nov 26, 2:06 am)
Re: [PATCH 10/11] x86/io_apic: add simply id set, Sebastian Andrzej Si ..., (Fri Nov 26, 4:03 am)
Re: [PATCH 04/11] x86/dtb: add irq host abstraction, Sebastian Andrzej Si ..., (Fri Nov 26, 7:19 am)
[PATCH] x86/io_apic: split setup_ioapic_ids_from_mpc() int ..., Sebastian Andrzej Si ..., (Fri Nov 26, 9:50 am)
Re: [PATCH 04/11] x86/dtb: add irq host abstraction, Benjamin Herrenschmidt, (Fri Nov 26, 2:36 pm)
Re: [PATCH 02/11] x86: Add device tree support, Benjamin Herrenschmidt, (Fri Nov 26, 2:42 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Fri Nov 26, 2:57 pm)
Re: [PATCH 04/11] x86/dtb: add irq host abstraction , Jon Loeliger, (Fri Nov 26, 8:11 pm)
Re: [PATCH 07/11] x86/dtb: add support for PCI devices bac ..., Benjamin Herrenschmidt, (Sat Nov 27, 3:33 pm)
Re: [PATCH 02/11] x86: Add device tree support, Sebastian Andrzej Si ..., (Sun Nov 28, 6:49 am)
Re: [PATCH 07/11] x86/dtb: add support for PCI devices bac ..., Sebastian Andrzej Si ..., (Sun Nov 28, 7:04 am)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Sebastian Andrzej Si ..., (Sun Nov 28, 9:04 am)
Re: [PATCH 02/11] x86: Add device tree support, Benjamin Herrenschmidt, (Sun Nov 28, 3:28 pm)
Re: [PATCH 07/11] x86/dtb: add support for PCI devices bac ..., Benjamin Herrenschmidt, (Sun Nov 28, 3:32 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Sun Nov 28, 3:53 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Mitch Bradley, (Sun Nov 28, 6:34 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, David Gibson, (Sun Nov 28, 7:22 pm)
Re: [sodaville] [PATCH 03/11] x86/dtb: Add a device tree f ..., Sebastian Andrzej Si ..., (Mon Nov 29, 12:36 pm)
Re: [sodaville] [PATCH 03/11] x86/dtb: Add a device tree f ..., Sebastian Andrzej Si ..., (Mon Nov 29, 12:44 pm)
Re: [sodaville] [PATCH 03/11] x86/dtb: Add a device tree f ..., Benjamin Herrenschmidt, (Mon Nov 29, 1:03 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Mon Nov 29, 1:05 pm)
Re: [sodaville] [PATCH 03/11] x86/dtb: Add a device tree f ..., Benjamin Herrenschmidt, (Mon Nov 29, 1:14 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Mitch Bradley, (Mon Nov 29, 1:32 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Mon Nov 29, 1:44 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Mitch Bradley, (Mon Nov 29, 2:32 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, David Gibson, (Mon Nov 29, 4:58 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Mon Nov 29, 7:50 pm)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Sebastian Andrzej Si ..., (Tue Nov 30, 4:20 am)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Sebastian Andrzej Si ..., (Tue Nov 30, 4:51 am)
Re: [PATCH 03/11] x86/dtb: Add a device tree for CE4100, Benjamin Herrenschmidt, (Tue Nov 30, 1:31 pm)
Re: [sodaville] [PATCH 04/11] x86/dtb: add irq host abstra ..., Sebastian Andrzej Si ..., (Wed Dec 1, 3:31 am)
Re: [PATCH 07/11] x86/dtb: add support for PCI devices bac ..., Sebastian Andrzej Si ..., (Thu Dec 2, 9:17 am)
[tip:x86/apic] x86: io_apic: Split setup_ioapic_ids_from_mpc(), tip-bot for Sebastia ..., (Mon Dec 6, 6:33 am)
Re: [sodaville] [PATCH 01/11] x86/kernel: remove condition ..., Sebastian Andrzej Si ..., (Wed Dec 8, 1:38 am)
[tip:x86/apic-cleanups] x86, ioapic: Avoid writing io_apic ..., tip-bot for Yinghai Lu, (Thu Dec 9, 1:56 pm)
Re: [PATCH 01/11] x86/kernel: remove conditional early rem ..., Sebastian Andrzej Si ..., (Thu Dec 16, 2:55 am)
Re: [PATCH 02/11] x86: Add device tree support, Grant Likely, (Thu Dec 30, 1:26 am)
Re: [PATCH 02/11] x86: Add device tree support, Rob Landley, (Thu Dec 30, 1:45 am)
Re: [PATCH 02/11] x86: Add device tree support, Grant Likely, (Thu Dec 30, 1:57 pm)
Re: [PATCH 02/11] x86: Add device tree support, Grant Likely, (Thu Dec 30, 1:58 pm)
Re: [sodaville] [PATCH 02/11] x86: Add device tree support, H. Peter Anvin, (Thu Dec 30, 5:51 pm)
Re: [sodaville] [PATCH 02/11] x86: Add device tree support, H. Peter Anvin, (Mon Jan 3, 11:06 am)
Re: [sodaville] [PATCH 02/11] x86: Add device tree support, H. Peter Anvin, (Mon Jan 3, 11:10 am)