[PATCH] x86: Fix warning in hw_nmi.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rakib Mullick
Date: Thursday, December 9, 2010 - 1:47 am

commit 0e2af2a9abf94b408ff70679b692a8644fed4aab fixed this warning, it
again introduced by commit 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a.
This patch fixes it by moving arch_trigger_all_cpu_backtrace few lines
above backtrace_mask's declaration.

We were warned by the following warning:

arch/x86/kernel/apic/hw_nmi.c:29: warning: ‘backtrace_mask’ defined but not used


Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index a0e71cb..0c294b3 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -25,10 +25,11 @@ u64 hw_nmi_get_sample_period(void)
 #endif


+#ifdef arch_trigger_all_cpu_backtrace
+
 /* For reliability, we're prepared to waste bits here. */
 static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;

-#ifdef arch_trigger_all_cpu_backtrace
 void arch_trigger_all_cpu_backtrace(void)
 {
 	int i;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: Fix warning in hw_nmi.c, Rakib Mullick, (Thu Dec 9, 1:47 am)
[tip:perf/core] x86: Address 'unused' warning in hw_nmi.c ..., tip-bot for Rakib Mu ..., (Thu Dec 9, 8:09 am)
Re: [PATCH] x86: Fix warning in hw_nmi.c, Don Zickus, (Thu Dec 9, 8:20 am)