On Tue, 7 Dec 2010, Feng Tang wrote:
quoted text
> On Tue, 7 Dec 2010 01:50:36 +0800
> Yinghai Lu <yinghai@kernel.org> wrote:
>  
> +static void assign_to_mp_irq(struct mpc_intsrc *m,
> +				    struct mpc_intsrc *mp_irq)
> +{
> +	mp_irq->dstapic = m->dstapic;
> +	mp_irq->type = m->type;
> +	mp_irq->irqtype = m->irqtype;
> +	mp_irq->irqflag = m->irqflag;
> +	mp_irq->srcbus = m->srcbus;
> +	mp_irq->srcbusirq = m->srcbusirq;
> +	mp_irq->dstirq = m->dstirq;

  Can we please use the mrst version with memcpy ?

quoted text
> +}
> +
> +static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> +					struct mpc_intsrc *m)
> +{
> +	if (mp_irq->dstapic != m->dstapic)
> +		return 1;
> +	if (mp_irq->type != m->type)
> +		return 2;
> +	if (mp_irq->irqtype != m->irqtype)
> +		return 3;
> +	if (mp_irq->irqflag != m->irqflag)
> +		return 4;
> +	if (mp_irq->srcbus != m->srcbus)
> +		return 5;
> +	if (mp_irq->srcbusirq != m->srcbusirq)
> +		return 6;
> +	if (mp_irq->dstirq != m->dstirq)
> +		return 7;
> +
> +	return 0;

  Same here. No caller is interested in the detailed return value.

Thanks,

	tglx
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/