Home » Mailing list archives » linux-kernel » 2010 » December » 6

Re: [PATCH] wmi: use memcmp instead of strncmp to compare GUIDs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Thadeu Lima de Souza Cascardo
Subject: Re: [PATCH] wmi: use memcmp instead of strncmp to compare GUIDs
Date: Monday, December 6, 2010 - 3:13 pm

On Mon, Dec 06, 2010 at 10:02:31PM +0000, Matthew Garrett wrote:

Hello, Matthew.

I consider this one a serious bug and with a trivial fix that should go
to Linus, for the next release candidate. I also consider it should go
to stable releases, and that's why I'm copying stable.

Any out-of-tree wmi driver written for systems with two or more GUIDs
containing any '\0' byte with a common prefix will fail to load because
of this bug. I've hit that, and that's how I found the bug.

Regards,
Cascardo.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] wmi: use memcmp instead of strncmp to compare GUIDs, Thadeu Lima de Souza ..., (Sun Nov 28, 2:46 pm)
Re: [PATCH] wmi: use memcmp instead of strncmp to compare ..., Jesper Juhl, (Sun Nov 28, 3:31 pm)
Re: [PATCH] wmi: use memcmp instead of strncmp to compare ..., Matthew Garrett, (Mon Dec 6, 3:02 pm)
Re: [PATCH] wmi: use memcmp instead of strncmp to compare ..., Thadeu Lima de Souza ..., (Mon Dec 6, 3:13 pm)
Re: [PATCH] wmi: use memcmp instead of strncmp to compare ..., Matthew Garrett, (Mon Dec 6, 3:17 pm)